Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

255 ec basic arithmetic in bbf #296

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

255 ec basic arithmetic in bbf #296

wants to merge 7 commits into from

Conversation

AntoineCyr
Copy link
Contributor

@AntoineCyr AntoineCyr commented Jan 25, 2025 •
edited
Loading

  1. new circuits needed for ECDSA implementation:
  • addition mod p
  • negation mod p
  • ec double
  • ec addition
  • ec incomplete addition
  1. Normalizing the variable and other things around the circuits

@AntoineCyr AntoineCyr requested a review from ayashunsky January 25, 2025 00:31
@AntoineCyr AntoineCyr self-assigned this Jan 25, 2025
@AntoineCyr AntoineCyr linked an issue Jan 25, 2025 that may be closed by this pull request
EC basic arithmetic in bbf #255
Open
@AntoineCyr AntoineCyr force-pushed the 255-ec-basic-arithmetic-in-bbf branch from 371c913 to 747bef0 Compare January 25, 2025 00:38
@AntoineCyr AntoineCyr force-pushed the 255-ec-basic-arithmetic-in-bbf branch 2 times, most recently from 41a3db8 to 70dadc5 Compare January 25, 2025 01:02
@AntoineCyr AntoineCyr force-pushed the 255-ec-basic-arithmetic-in-bbf branch from 70dadc5 to 5ad1ad8 Compare January 25, 2025 01:34
@github-actions GitHub Actions
Copy link

Clang Test Results

  174 files  +  6    174 suites  +6   16m 14s ⏱️ +16s
8 543 tests +104  8 537 ✅ +104  6 💤 ±0  0 ❌ ±0 
8 609 runs  +104  8 603 ✅ +104  6 💤 ±0  0 ❌ ±0 

Results for commit 5ad1ad8. ± Comparison against base commit 1491314.

This pull request removes 6 and adds 110 tests. Note that renamed tests count towards both. 
pack_imploder_test_suite ‑ be_to_be_1
pack_imploder_test_suite ‑ be_to_be_2
pack_imploder_test_suite ‑ be_to_le_1
pack_imploder_test_suite ‑ be_to_le_2
pack_imploder_test_suite ‑ be_to_le_3
pack_imploder_test_suite ‑ bubb_to_lulb_4

blueprint_plonk_test_suite ‑ blueprint_plonk_bbf_addition_mod_p_test
blueprint_plonk_test_suite ‑ blueprint_plonk_bbf_choice_function_pallas_test
blueprint_plonk_test_suite ‑ blueprint_plonk_bbf_choice_function_vesta_test
blueprint_plonk_test_suite ‑ blueprint_plonk_bbf_ec_double_test
blueprint_plonk_test_suite ‑ blueprint_plonk_bbf_ec_full_add_test
blueprint_plonk_test_suite ‑ blueprint_plonk_bbf_ec_incomplete_add_test
blueprint_plonk_test_suite ‑ blueprint_plonk_bbf_negation_mod_p_test
lpc_math_polynomial_suite ‑ lpc_basic_skipping_layers_test
lpc_math_polynomial_suite ‑ lpc_dfs_basic_test
lpc_params_test_suite ‑ lpc_batches_num_3_test
…

@github-actions GitHub Actions
Copy link

Gcc Test Results

  174 files  +6    174 suites  +6   17m 25s ⏱️ +41s
8 543 tests +7  8 537 ✅ +7  6 💤 ±0  0 ❌ ±0 
8 609 runs  +7  8 603 ✅ +7  6 💤 ±0  0 ❌ ±0 

Results for commit 5ad1ad8. ± Comparison against base commit 1491314.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayashunsky ayashunsky Awaiting requested review from ayashunsky

At least 1 approving review is required to merge this pull request.

Assignees

@AntoineCyr AntoineCyr

Labels
blueprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EC basic arithmetic in bbf
1 participant
@AntoineCyr