Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing satisfied assert in bbf test files #259

Closed
Valeh2012 opened this issue Jan 10, 2025 · 0 comments · Fixed by #300
Closed

Missing satisfied assert in bbf test files #259

Valeh2012 opened this issue Jan 10, 2025 · 0 comments · Fixed by #300
Assignees

Comments

@Valeh2012
Copy link
Contributor

Currently, some bbf components are tested using simple code snippet:

...
auto [at, A, desc] = B.assign(raw_input);
std::cout << "Is_satisfied = " << B.is_satisfied(at) << std::endl;

The missing assert(B.is_satisfied(at)) may let errors be unnoticed in github action logs.
Currently affected components:

  • poseidon.cpp
  • opcode_poc.cpp
  • tester.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants