Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented padding at the stage of block_to_field_wrapper #280

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implemented padding at the stage of block_to_field_wrapper #280

wants to merge 1 commit into from

Conversation

vo-nil
Copy link
Contributor

@vo-nil vo-nil commented Jan 17, 2025

This PR adds padding option (enabled by default) to conditional_block_to_field_wrapper.
closes #273

@vo-nil vo-nil self-assigned this Jan 17, 2025
@vo-nil vo-nil force-pushed the 273-poseidon-padding branch 3 times, most recently from b651dca to b222c43 Compare January 21, 2025 13:15
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 21, 2025 •
edited
Loading

Clang Test Results

  168 files  ± 0    168 suites  ±0   15m 41s ⏱️ -17s
8 538 tests +99  8 532 ✅ +99  6 💤 ±0  0 ❌ ±0 
8 604 runs  +99  8 598 ✅ +99  6 💤 ±0  0 ❌ ±0 

Results for commit 4dab204. ± Comparison against base commit 1491314.

This pull request removes 7 and adds 106 tests. Note that renamed tests count towards both. 
blueprint_plonk_test_suite ‑ blueprint_non_native_multiplication_pallas
pack_imploder_test_suite ‑ be_to_be_1
pack_imploder_test_suite ‑ be_to_be_2
pack_imploder_test_suite ‑ be_to_le_1
pack_imploder_test_suite ‑ be_to_le_2
pack_imploder_test_suite ‑ be_to_le_3
pack_imploder_test_suite ‑ bubb_to_lulb_4

blueprint_plonk_test_suite ‑ blueprint_non_native_addition_pallas
lpc_math_polynomial_suite ‑ lpc_basic_skipping_layers_test
lpc_math_polynomial_suite ‑ lpc_dfs_basic_test
lpc_params_test_suite ‑ lpc_batches_num_3_test
lpc_params_test_suite ‑ lpc_different_hash_types_test
pack_equal_test_suite ‑ bubb_to_bubb_1
pack_equal_test_suite ‑ bubb_to_bubb_2
pack_equal_test_suite ‑ bubb_to_bubb_3
pack_equal_test_suite ‑ bubb_to_bulb_1
pack_equal_test_suite ‑ bubb_to_bulb_2
…

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 21, 2025 •
edited
Loading

Gcc Test Results

  168 files  ±0    168 suites  ±0   16m 40s ⏱️ -4s
8 538 tests +2  8 532 ✅ +2  6 💤 ±0  0 ❌ ±0 
8 604 runs  +2  8 598 ✅ +2  6 💤 ±0  0 ❌ ±0 

Results for commit 4dab204. ± Comparison against base commit 1491314.

♻️ This comment has been updated with latest results.

@vo-nil vo-nil requested a review from martun January 21, 2025 16:37
@vo-nil vo-nil marked this pull request as ready for review January 21, 2025 16:37
@vo-nil vo-nil enabled auto-merge January 21, 2025 17:51
@vo-nil
Implemented padding at the stage of block_to_field_wrapper
4dab204 
Added example with non-byte input to poseidon

fix transcript test

Fix parallel version
@vo-nil vo-nil force-pushed the 273-poseidon-padding branch from b222c43 to 4dab204 Compare January 24, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martun martun Awaiting requested review from martun

At least 1 approving review is required to merge this pull request.

Assignees

@vo-nil vo-nil

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review padding in poseidon hash
1 participant
@vo-nil