Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET 6/7 are EOL #326335

Open
9 of 17 tasks
JamieMagee opened this issue Jul 11, 2024 · 24 comments
Open
9 of 17 tasks

.NET 6/7 are EOL #326335

JamieMagee opened this issue Jul 11, 2024 · 24 comments
Labels
5. scope: tracking Long-lived issue tracking long-term fixes or multiple sub-problems 6.topic: dotnet Language: .NET 6.topic: old-versions Tickets pertaining to ongoing support of outdated versions of packages

Comments

@JamieMagee
Copy link
Member

JamieMagee commented Jul 11, 2024

.NET 7 went EOL on 14th May 20241. Similar to #202572, which dealt with the deprecation of .NET Core 3.1, we should make an effort to update or patch packages whick rely on .NET 7.

Packages

Footnotes

  1. https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core

@gepbird gepbird added the 5. scope: tracking Long-lived issue tracking long-term fixes or multiple sub-problems label Jul 20, 2024
@YoshiRulz YoshiRulz added the 6.topic: dotnet Language: .NET label Jul 30, 2024
@konradmalik
Copy link
Contributor

netcoredbg will stop relying on dotnet 7 with this PR: #329845
roslyn-ls was upgraded with #318497

@pyrox0
Copy link
Member

pyrox0 commented Jul 31, 2024

pinta now uses dotnet 8, see #327375
fsautocomplete relies only on the 8.0 sdk at runtime but still needs 6 and 7 for building, changed in #326130

@FliegendeWurst FliegendeWurst added the 6.topic: old-versions Tickets pertaining to ongoing support of outdated versions of packages label Oct 16, 2024
@gepbird
Copy link
Contributor

gepbird commented Nov 23, 2024

Related: #358533

@gepbird
Copy link
Contributor

gepbird commented Dec 1, 2024

IMO we can use this issue for also tracking .NET 6 packages:

Other .NET 7 packages:

@corngood
Copy link
Contributor

corngood commented Dec 2, 2024

beatsabermodmanager: #361128

@konradmalik
Copy link
Contributor

removing both 6 and 7 from roslyn-ls: #357963 - looking for reviewers/mergers.

@gepbird gepbird mentioned this issue Dec 4, 2024
13 tasks
@GGG-KILLER

This comment has been minimized.

@GGG-KILLER
Copy link
Contributor

GGG-KILLER commented Dec 18, 2024

eventstore has a newer version upstream with .NET 8 support, however the license has been changed to an unfree one.

cc: @puffnfresh @mdarocha

@GGG-KILLER
Copy link
Contributor

GGG-KILLER commented Dec 18, 2024

msbuild repository has been archived. We should probably remove it.

I'll do it in a separate PR from the ones I'm doing currently. I'll have to figure out how removals work in pkgs/by-name.

cc: @jirkadanek

@GGG-KILLER
Copy link
Contributor

GGG-KILLER commented Dec 18, 2024

Unable to upgrade naps2 as it uses some APIs that are marked as preview when building with a patch that changes TargetFrameworks to net8 instead of net6:

...
/build/source/NAPS2.Escl.Server/EsclApiController.cs(310,62): error CA2252: Using 'Aborted' requires opting into preview features. See https://aka.ms/dotnet-warnings/preview-features for more information. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2252) [/build/source/NAPS2.Escl.Server/NAPS2.Escl.Server.csproj::TargetFramework=net8]
/build/source/NAPS2.Escl.Server/EsclApiController.cs(322,40): error CA2252: Using 'ContentType' requires opting into preview features. See https://aka.ms/dotnet-warnings/preview-features for more information. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2252) [/build/source/NAPS2.Escl.Server/NAPS2.Escl.Server.csproj::TargetFramework=net8]
/build/source/NAPS2.Escl.Server/EsclApiController.cs(325,23): error CA2252: Using 'WriteDocumentTo' requires opting into preview features. See https://aka.ms/dotnet-warnings/preview-features for more information. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2252) [/build/source/NAPS2.Escl.Server/NAPS2.Escl.Server.csproj::TargetFramework=net8]
/build/source/NAPS2.Escl.Server/EsclApiController.cs(339,37): error CA2252: Using 'Processing' requires opting into preview features. See https://aka.ms/dotnet-warnings/preview-features for more information. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2252) [/build/source/NAPS2.Escl.Server/NAPS2.Escl.Server.csproj::TargetFramework=net8]
/build/source/NAPS2.Escl.Server/EsclApiController.cs(339,62): error CA2252: Using 'Completed' requires opting into preview features. See https://aka.ms/dotnet-warnings/preview-features for more information. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2252) [/build/source/NAPS2.Escl.Server/NAPS2.Escl.Server.csproj::TargetFramework=net8]
    1 Warning(s)
    163 Error(s)

Time Elapsed 00:00:04.39

cc: @eliandoran

@GGG-KILLER
Copy link
Contributor

space-station-14-launcher has an upgrade upstream (space-wizards/SS14.Launcher@ed386b8) but hasn't turned into a release yet, should an unstable version of it be made?

There are no maintainers so I'm unsure if this package should be kept at all unless if someone else picks it up.

@GGG-KILLER
Copy link
Contributor

Taking care of alttpr-opentracker, am2rlauncher, avalonia-ilspy, clr-loader, dafny, formula, gh-gei, ilspycmd, inklecate and knossosnet over at #366067

@eliandoran
Copy link
Contributor

Unable to upgrade naps2 as it uses some APIs that are marked as preview when building with a patch that changes TargetFrameworks to net8 instead of net6:

OK, I'll have a look. Maybe in the newer version of NAPS2 they updated to a newer version of .NET.

@FliegendeWurst
Copy link
Member

msbuild repository has been archived. We should probably remove it.

There is the newer https://github.com/dotnet/msbuild/ we can use instead.

@oynqr
Copy link
Contributor

oynqr commented Dec 18, 2024

space-station-14-launcher has an upgrade upstream (space-wizards/SS14.Launcher@ed386b8) but hasn't turned into a release yet, should an unstable version of it be made?

There are no maintainers so I'm unsure if this package should be kept at all unless if someone else picks it up.

space-station-14-launcher no longer depends on dotnet 6 since #362431 was merged.

On another note, ever since #359409, the launcher has been broken for me (the launcher itself starts fine, but it can't launch the game). Since apparently only myself and one other unfortunate soul on the ss14 discord have ran into this, I'd guess the overall usage of this package is low.

@jDanek
Copy link

jDanek commented Dec 18, 2024

msbuild repository has been archived. We should probably remove it.

I'll do it in a separate PR from the ones I'm doing currently. I'll have to figure out how removals work in pkgs/by-name.

cc: @jirkadanek

Hi, I was wondering why I got the notification. I get it now, same name different person. Could still be a half-brother :D

Merry Christmas wishes jDanek :D

image

@GGG-KILLER
Copy link
Contributor

msbuild repository has been archived. We should probably remove it.

There is the newer https://github.com/dotnet/msbuild/ we can use instead.

That's already part of the .NET SDK, I think the only use it had was compiling .NET Framework projects on Linux, but I don't know how to move on with those as I don't think there are .NET Framework targeting packs for Linux

@GGG-KILLER
Copy link
Contributor

Hi, I was wondering why I got the notification. I get it now, same name different person. Could still be a half-brother :D

Merry Christmas wishes jDanek :D

Yeah, my bad 😅
I got used to most people using their GitHub usernames in the maintainers list that I didn't double check, I'm sorry.

@konradmalik
Copy link
Contributor

konradmalik commented Dec 20, 2024

hmm, any idea what could've happened to roslyn-ls In the past week?
In my flake that uses it I've removed insecurePackages (dotnet 6 and 7 because my PR got merged) on Dec 10th and it worked fine, but today it started generating errors about insecure dotnet 6 again, and the trace points to roslyn-ls. I see there was only this 1cd9516 but it does not look like it could change that behavior...

I have automatic dep updates on that flake every Friday, so it worked on Dec 10th (manual update), worked on Dec 13th, and stopped working somewhere between Dec 13th and Dec 20th (today).

In particular, this works: https://github.com/konradmalik/neovim-flake/actions/runs/12253416030, and today this failed: https://github.com/konradmalik/neovim-flake/actions/runs/12424292928

@GGG-KILLER
Copy link
Contributor

GGG-KILLER commented Dec 20, 2024

hmm, any idea what could've happened to roslyn-ls In the past week?
In my flake that uses it I've removed insecurePackages (dotnet 6 and 7 because my PR got merged)

Your PR did not remove the dependency on .NET 6, it's still in there, even though only packages and targetingPackages are being used, those are also insecure.
That's why it's still (or should be) as pending on the list.

@konradmalik
Copy link
Contributor

@GGG-KILLER thanks, this makes sense. @corngood suggested that this could help with the insecurePackages warning. Seems like it does not, which is fine, but I still do not understand why it did not generate warnings for me for more than a week and started to do so again today.

@GGG-KILLER
Copy link
Contributor

GGG-KILLER commented Dec 20, 2024

Seems like it does not,which is fine, but I still do not understand why it did not generate warnings for me for more than a week and started to do so again today.

It used to, before we merged a change that made usage of packages from .NET 6 and 7 generate insecure warnings.
So for a short while that "solved" the warnings (but shouldn't have, which is why we made that change).

This was done in #363439

@GGG-KILLER
Copy link
Contributor

gh-gei was done in #366482 already. Will remove it from my PR.

DavSanchez added a commit to DavSanchez/nix-dotfiles that referenced this issue Jan 12, 2025
DavSanchez added a commit to DavSanchez/nix-dotfiles that referenced this issue Jan 12, 2025
* fix(dips): permit botnet 6

Revert after NixOS/nixpkgs#360592 and NixOS/nixpkgs#326335 are sorted out.

* fix(deps): allow asp net core
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5. scope: tracking Long-lived issue tracking long-term fixes or multiple sub-problems 6.topic: dotnet Language: .NET 6.topic: old-versions Tickets pertaining to ongoing support of outdated versions of packages
Projects
None yet
Development

No branches or pull requests