linuxPackages_latest.bbswitch no longer compiles

[peti]

In current versions of the master branch, linuxPackages_latest.bbswitch is broken:

these derivations will be built:
  /nix/store/hjmg653y5xcmxqk2bjbg7ar7plh607fa-bbswitch-0.8-5.6.4.drv
these paths will be fetched (86.40 MiB download, 198.24 MiB unpacked):
  /nix/store/0ynr7amcx6kngwz61r7cvn332bq94ibj-v0.8.tar.gz
  /nix/store/1g952pwgphp07zrdf053ajc5vqkbjawj-util-linux-2.33.2-bin
  /nix/store/5r7621raj5mi2v0qza8l2zv1sfk9jccv-102.patch
  /nix/store/asbah5gmfid3mwviw6cs34px4bspddcm-mpfr-4.0.2
  /nix/store/fjgkk62q80xgbmsv920irjzzvhdnl9z7-flex-2.6.4
  /nix/store/h17xl046fhziqc7h9923d7zsrsjy08gy-gnum4-1.4.18
  /nix/store/j7prclp01a6f7czi2x2xsfan1yjbfvvh-util-linux-2.33.2
  /nix/store/mz71x365z4q0n0hs6s7162shfcqi1z4f-mpfr-4.0.2-dev
  /nix/store/plicagvvy5qqj7lcyy9v2ygkwx14ndck-util-linux-2.33.2-dev
  /nix/store/rwdmv9ivpc27x2mzkkg5pr0ajb6c9lgd-libmpc-1.1.0
  /nix/store/sg1ikvdl0saq9lm7yayzqwgyz0xy89nb-linux-5.6.4
  /nix/store/vkac7raflnrhgslw0j5fj1iv6ghzz0f7-linux-5.6.4-dev
copying path '/nix/store/0ynr7amcx6kngwz61r7cvn332bq94ibj-v0.8.tar.gz' from 'https://cache.nixos.org'...
copying path '/nix/store/sg1ikvdl0saq9lm7yayzqwgyz0xy89nb-linux-5.6.4' from 'https://cache.nixos.org'...
copying path '/nix/store/5r7621raj5mi2v0qza8l2zv1sfk9jccv-102.patch' from 'https://cache.nixos.org'...
copying path '/nix/store/h17xl046fhziqc7h9923d7zsrsjy08gy-gnum4-1.4.18' from 'https://cache.nixos.org'...
copying path '/nix/store/asbah5gmfid3mwviw6cs34px4bspddcm-mpfr-4.0.2' from 'https://cache.nixos.org'...
copying path '/nix/store/j7prclp01a6f7czi2x2xsfan1yjbfvvh-util-linux-2.33.2' from 'https://cache.nixos.org'...
copying path '/nix/store/fjgkk62q80xgbmsv920irjzzvhdnl9z7-flex-2.6.4' from 'https://cache.nixos.org'...
copying path '/nix/store/rwdmv9ivpc27x2mzkkg5pr0ajb6c9lgd-libmpc-1.1.0' from 'https://cache.nixos.org'...
copying path '/nix/store/mz71x365z4q0n0hs6s7162shfcqi1z4f-mpfr-4.0.2-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/1g952pwgphp07zrdf053ajc5vqkbjawj-util-linux-2.33.2-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/plicagvvy5qqj7lcyy9v2ygkwx14ndck-util-linux-2.33.2-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/vkac7raflnrhgslw0j5fj1iv6ghzz0f7-linux-5.6.4-dev' from 'https://cache.nixos.org'...
building '/nix/store/hjmg653y5xcmxqk2bjbg7ar7plh607fa-bbswitch-0.8-5.6.4.drv'...
unpacking sources
unpacking source archive /nix/store/0ynr7amcx6kngwz61r7cvn332bq94ibj-v0.8.tar.gz
source root is bbswitch-0.8
setting SOURCE_DATE_EPOCH to timestamp 1386199326 of file bbswitch-0.8/dkms/dkms.conf
patching sources
applying patch /nix/store/5r7621raj5mi2v0qza8l2zv1sfk9jccv-102.patch
patching file bbswitch.c
patching file bbswitch.c
configuring
no configure script, doing nothing
building
build flags: SHELL=/nix/store/z1l2n01xdfcm9bkkir83c32mkpvv51zq-bash-4.4-p23/bin/bash
make -C /nix/store/vkac7raflnrhgslw0j5fj1iv6ghzz0f7-linux-5.6.4-dev/lib/modules/5.6.4/build M="$(pwd)" modules
make[1]: Entering directory '/nix/store/vkac7raflnrhgslw0j5fj1iv6ghzz0f7-linux-5.6.4-dev/lib/modules/5.6.4/build'
  CC [M]  /build/bbswitch-0.8/bbswitch.o
/build/bbswitch-0.8/bbswitch.c: In function 'bbswitch_init':
/build/bbswitch-0.8/bbswitch.c:491:63: error: passing argument 4 of 'proc_create' from incompatible pointer type [-Werror=incompatible-pointer-types]
  491 |     acpi_entry = proc_create("bbswitch", 0664, acpi_root_dir, &bbswitch_fops);
      |                                                               ^~~~~~~~~~~~~~
      |                                                               |
      |                                                               struct file_operations *
In file included from /nix/store/vkac7raflnrhgslw0j5fj1iv6ghzz0f7-linux-5.6.4-dev/lib/modules/5.6.4/source/include/acpi/acpi_bus.h:83,
                 from /nix/store/vkac7raflnrhgslw0j5fj1iv6ghzz0f7-linux-5.6.4-dev/lib/modules/5.6.4/source/include/linux/acpi.h:32,
                 from /build/bbswitch-0.8/bbswitch.c:32:
/nix/store/vkac7raflnrhgslw0j5fj1iv6ghzz0f7-linux-5.6.4-dev/lib/modules/5.6.4/source/include/linux/proc_fs.h:64:24: note: expected 'const struct proc_ops *' but argument is of type 'struct file_operations *'
   64 | struct proc_dir_entry *proc_create(const char *name, umode_t mode, struct proc_dir_entry *parent, const struct proc_ops *proc_ops);
      |                        ^~~~~~~~~~~
cc1: some warnings being treated as errors
make[3]: *** [/nix/store/vkac7raflnrhgslw0j5fj1iv6ghzz0f7-linux-5.6.4-dev/lib/modules/5.6.4/source/scripts/Makefile.build:268: /build/bbswitch-0.8/bbswitch.o] Error 1
make[2]: *** [/nix/store/vkac7raflnrhgslw0j5fj1iv6ghzz0f7-linux-5.6.4-dev/lib/modules/5.6.4/source/Makefile:1683: /build/bbswitch-0.8] Error 2
make[1]: *** [/nix/store/vkac7raflnrhgslw0j5fj1iv6ghzz0f7-linux-5.6.4-dev/lib/modules/5.6.4/source/Makefile:180: sub-make] Error 2
make[1]: Leaving directory '/nix/store/vkac7raflnrhgslw0j5fj1iv6ghzz0f7-linux-5.6.4-dev/lib/modules/5.6.4/build'
make: *** [Makefile:13: default] Error 2
builder for '/nix/store/hjmg653y5xcmxqk2bjbg7ar7plh607fa-bbswitch-0.8-5.6.4.drv' failed with exit code 2
error: build of '/nix/store/hjmg653y5xcmxqk2bjbg7ar7plh607fa-bbswitch-0.8-5.6.4.drv' failed

[peti]

Upstream bug appears to be Bumblebee-Project/bbswitch#198.

[peti]

Upstream fix is in Bumblebee-Project/bbswitch@0b11f33.

[thiagokokada]

@peti Could we have this backported to 20.03? Because it is also broken there.

[peti]

Sure, just open a PR and ping me. I'll be happy to merge it.