haskellPackages: fixes #202050
haskellPackages: fixes #202050
Conversation
ncfavier
requested review from
cdepillabout,
sternenseemann and
maralorn
as code owners
ncfavier
force-pushed
the
haskell-fix
branch
from
e24057d to
875c4d5
Compare
pkgs/top-level/all-packages.nix
Outdated
| # Please update doc/languages-frameworks/haskell.section.md, “Our | ||
| # current default compiler is”, if you bump this: |
There was a problem hiding this comment.
This has been moved to https://haskell4nix.readthedocs.io/nixpkgs-users-guide.html, which still says 8.10.x. It would probably be better not to hardcode the current default in the docs and instead give instructions on finding out the default compiler version.
There was a problem hiding this comment.
Well, we will bring the docs back into the nixpkgs manual really soon (TM), then updating this will make sense again.
|
Really cool, that you are working on this! Obviously this is a little bit of work to review, I hope we‘ll get to it soon. |
ncfavier
force-pushed
the
haskell-fix
branch
from
3cf4292 to
ea84ce7
Compare
| # Test suite has overly strict bounds on tasty. | ||
| # Test suite has overly strict bounds on tasty, jailbreaking fails. | ||
| # https://github.com/input-output-hk/nothunks/issues/9 | ||
| nothunks = doJailbreak super.nothunks; | ||
| nothunks = dontCheck super.nothunks; |
There was a problem hiding this comment.
Not sure how we even deal with this in principle
There was a problem hiding this comment.
Not sure, how jailbreaking fails, but if it is because of cabal flags then we patch (or regex).
Disabling checks is also okay, I guess.
There was a problem hiding this comment.
I think nothunks really does depend on an older version of tasty-hedgehog (or hedgehog) than we have in nixpkgs.
There was a problem hiding this comment.
nothunks> test/Test/NoThunks/Class.hs:652:17: error:
nothunks> • Couldn't match expected type: IO
nothunks> (Hedgehog.Internal.Report.Report Result)
nothunks> with actual type: Property
nothunks> -> m0 (Hedgehog.Internal.Report.Report Result)
nothunks> • Probable cause: ‘checkNamed’ is applied to too few arguments
nothunks> In the expression:
nothunks> checkNamed r EnableColor (Just "EXPECTED FAILURE") p
nothunks> In the second argument of ‘($)’, namely
nothunks> ‘\ r -> checkNamed r EnableColor (Just "EXPECTED FAILURE") p’
nothunks> In the second argument of ‘($)’, namely
nothunks> ‘displayRegion
nothunks> $ \ r -> checkNamed r EnableColor (Just "EXPECTED FAILURE") p’
nothunks> |
nothunks> 652 | checkNamed r EnableColor (Just "EXPECTED FAILURE") p
nothunks> | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
Alright, I'll go ahead and merge in. @ncfavier Thanks a lot for working on this, this is a big help! If you'd like to continue helping, definitely feel free to keep an eye on #202022 and https://github.com/cdepillabout/nix-haskell-updates-status |
Makes
mergeableevaluate#202022