Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Scaled QL and Scaled MQL #148

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Add Scaled QL and Scaled MQL #148

wants to merge 11 commits into from

Conversation

marcozanotti
Copy link
Contributor

PR for #146

@jmoralez
Copy link
Member

Thanks. Could you extract the scale into a function? I think it's repeated in several places now

@marcozanotti
Copy link
Contributor Author

Hi @jmoralez,
I added into losses.py the _scale_loss function and used it in mase, msse, scaled_quantile_loss and scaled_mql.
The _scale_loss function has one new parameter that specifies the type of error to be used in the scaling process.

@jmoralez jmoralez linked an issue Feb 21, 2025 that may be closed by this pull request
[losses] Add Scaled QL and Scaled MQL #146
Open
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

jmoralez
jmoralez approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@jmoralez jmoralez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmoralez jmoralez jmoralez approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[losses] Add Scaled QL and Scaled MQL
2 participants
@marcozanotti @jmoralez