Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign MacOS binaries #90

Open
MakMuftic opened this issue Oct 23, 2020 · 4 comments
Open

Sign MacOS binaries #90

MakMuftic opened this issue Oct 23, 2020 · 4 comments
Labels
enhancement New feature with low priority

Comments

@MakMuftic
Copy link
Member

No description provided.

@MakMuftic MakMuftic added the enhancement New feature with low priority label Oct 23, 2020
@mpetrun5 mpetrun5 mentioned this issue Oct 28, 2020
Merged
@mpetrun5 mpetrun5 self-assigned this Oct 28, 2020
@mpetrunic mpetrunic mentioned this issue Dec 28, 2020
Closed
@mpetrunic
Copy link
Member

  • add .zip extension to mac and linux builds in release (also add version and arch to zip filename)
  • don't archive windows binary
  • Use https://github.com/NodeFactoryIo/windows-codesign-action to sign windows binary (repo has access to org secrets WINDOWS_CODESIGN_CERT and WINDOWS_CODESIGN_PASS)
    • uses nodefactoryio/windows-codesign-action@master

@mpetrunic
Copy link
Member

cc @mpetrun5

@mpetrun5
Copy link
Member

  • add .zip extension to mac and linux builds in release (also add version and arch to zip filename)

  • don't archive windows binary

  • Use https://github.com/NodeFactoryIo/windows-codesign-action to sign windows binary (repo has access to org secrets WINDOWS_CODESIGN_CERT and WINDOWS_CODESIGN_PASS)

    • uses nodefactoryio/windows-codesign-action@master

Shouldn't I sign windows binary and then zip it for consistency?

@mpetrunic
Copy link
Member

Yeah ok, let's zip it

@mpetrunic mpetrunic changed the title Sign binaries Sign MacOS binaries Jan 7, 2021
@mpetrun5 mpetrun5 removed their assignment Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature with low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mpetrunic @mpetrun5 @MakMuftic