Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot reposition either bar #125

Open
Fashtas opened this issue Jan 23, 2023 · 4 comments
Open

Cannot reposition either bar #125

Fashtas opened this issue Jan 23, 2023 · 4 comments

Comments

@Fashtas
Copy link

Fashtas commented Jan 23, 2023

No console errors, using PF2E game system.

No matter what values entered into the position settings and no matter how many times I refresh foundry (restarting server on forge too) the bars remain in the default position

@Norc
Copy link
Owner

Norc commented Jan 23, 2023 via email

@tehguitarist
Copy link

tehguitarist commented Mar 24, 2023

This may be a module conflict, I just discovered I could shift the hotbar WITHOUT Dorako UI enabled, but with it enabled, I couldn't. I've raised an issue in the UI module git. Mind you, I was shifting by using dev tools, not actually in the settings.

Dorako/pf2e-dorako-ui#177

@tehguitarist
Copy link

tehguitarist commented Mar 26, 2023

See the below from Dorako on fixing the issue. I think maybe an if statement checking for dorako-ui module enabled, and if so, set the hotbar position as absolute.
A cleaner option, especially if the module shifts the hotbar, might be a checkbox in the settings for the "fix". If I get some time I'll see if I can hack something together, but I am neither a programmer (I wish - but bad career choices led me down another path im climbing out of, and self teaching myself software dev) nor have much experience with CSS (like, minus dev tool hacking). This fix could also be added in the custom CSS section of Dorako UI as a quick fix too.

From Dorako:


_If you want to use the Custom hotbar settings to move the hotbar, you can set the positioning back to absolute like this:

.dorako-ui#custom-hotbar { position: absolute; }

You can also set the offsets there, if you want:
.dorako-ui#custom-hotbar { position: absolute; bottom: <yourvaluehere>; left: <yourvaluehere>; }_


My idea for a quick hacky fix would be (mind you, variable names are probably wrong):

if (module.dorako-ui) { .dorako-ui#custom-hotbar { position: absolute; } // OR .dorako-ui#custom-hotbar { position: absolute; bottom: --custom-hotbar-bottom-pos; left: --custom-hotbar-left-pos; } };

@tehguitarist
Copy link

I've done some hunting and it looks like adding this to custom CSS does the trick:

div#custom-hotbar.flexrow.dorako-ui { position: absolute; }

I've been trying to work out how to add that to the style sheet (minus div#) and make it conditional on finding the pf2e-dorako-ui module is active (game.modules.get("pf2e-dorako-ui").active gives a conditional) but can't work that out. I'm not sure if adding CSS to a sheet where the thing it references doesn't exist would cause problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants