From 1fd79d593d06b291dd1e252b6daf32417627d54e Mon Sep 17 00:00:00 2001 From: Jeff Kluge Date: Wed, 8 Jan 2025 09:02:07 -0800 Subject: [PATCH 1/4] Use .NET SDK 9.0.2xx for integration tests --- build/DotNetSdkTestVersions.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build/DotNetSdkTestVersions.txt b/build/DotNetSdkTestVersions.txt index 14d40d5aa45..23c5a5c6e64 100644 --- a/build/DotNetSdkTestVersions.txt +++ b/build/DotNetSdkTestVersions.txt @@ -1,3 +1,3 @@ # Each line represents arguments for the .NET SDK installer script (https://learn.microsoft.com/dotnet/core/tools/dotnet-install-script) --Channel 9.0.1xx -Quality daily +-Channel 9.0.2xx -Quality daily -Channel 8.0 -Runtime dotnet From 8ea9113df82c15c34a33eb7ebe51dc95ae2c74ed Mon Sep 17 00:00:00 2001 From: Jeff Kluge Date: Thu, 9 Jan 2025 09:59:21 -0800 Subject: [PATCH 2/4] Add test output to DotnetWhyTests --- .../DotnetIntegrationTestFixture.cs | 2 +- .../Dotnet.Integration.Test/DotnetWhyTests.cs | 39 ++++++++++--------- 2 files changed, 22 insertions(+), 19 deletions(-) diff --git a/test/NuGet.Core.FuncTests/Dotnet.Integration.Test/DotnetIntegrationTestFixture.cs b/test/NuGet.Core.FuncTests/Dotnet.Integration.Test/DotnetIntegrationTestFixture.cs index 728f212a47f..0a81ae1b011 100644 --- a/test/NuGet.Core.FuncTests/Dotnet.Integration.Test/DotnetIntegrationTestFixture.cs +++ b/test/NuGet.Core.FuncTests/Dotnet.Integration.Test/DotnetIntegrationTestFixture.cs @@ -227,7 +227,7 @@ internal CommandRunnerResult RunDotnetExpectSuccess(string workingDirectory, str /// The command-line arguments to pass to dotnet. /// An optional containing environment variables to use when executing the command. internal CommandRunnerResult RunDotnetExpectFailure(string workingDirectory, string args = "", IReadOnlyDictionary environmentVariables = null, ITestOutputHelper testOutputHelper = null) - => RunDotnet(workingDirectory, args, expectSuccess: false, environmentVariables); + => RunDotnet(workingDirectory, args, expectSuccess: false, environmentVariables, testOutputHelper); private CommandRunnerResult RunDotnet(string workingDirectory, string args = "", bool expectSuccess = true, IReadOnlyDictionary environmentVariables = null, ITestOutputHelper testOutputHelper = null) { diff --git a/test/NuGet.Core.FuncTests/Dotnet.Integration.Test/DotnetWhyTests.cs b/test/NuGet.Core.FuncTests/Dotnet.Integration.Test/DotnetWhyTests.cs index 8ca1bec2cc4..f30c769e8e2 100644 --- a/test/NuGet.Core.FuncTests/Dotnet.Integration.Test/DotnetWhyTests.cs +++ b/test/NuGet.Core.FuncTests/Dotnet.Integration.Test/DotnetWhyTests.cs @@ -9,6 +9,7 @@ using NuGet.Test.Utility; using NuGet.XPlat.FuncTest; using Xunit; +using Xunit.Abstractions; namespace Dotnet.Integration.Test { @@ -18,10 +19,12 @@ public class DotnetWhyTests private static readonly string ProjectName = "Test.Project.DotnetNugetWhy"; private readonly DotnetIntegrationTestFixture _testFixture; + private readonly ITestOutputHelper _testOutputHelper; - public DotnetWhyTests(DotnetIntegrationTestFixture testFixture) + public DotnetWhyTests(DotnetIntegrationTestFixture testFixture, ITestOutputHelper testOutputHelper) { _testFixture = testFixture; + _testOutputHelper = testOutputHelper; } [Fact] @@ -45,12 +48,12 @@ await SimpleTestPackageUtility.CreatePackagesAsync( packageY); string addPackageCommandArgs = $"add {project.ProjectPath} package {packageX.Id}"; - CommandRunnerResult addPackageResult = _testFixture.RunDotnetExpectSuccess(pathContext.SolutionRoot, addPackageCommandArgs); + CommandRunnerResult addPackageResult = _testFixture.RunDotnetExpectSuccess(pathContext.SolutionRoot, addPackageCommandArgs, testOutputHelper: _testOutputHelper); string whyCommandArgs = $"nuget why {project.ProjectPath} {packageY.Id}"; // Act - CommandRunnerResult result = _testFixture.RunDotnetExpectSuccess(pathContext.SolutionRoot, whyCommandArgs); + CommandRunnerResult result = _testFixture.RunDotnetExpectSuccess(pathContext.SolutionRoot, whyCommandArgs, testOutputHelper: _testOutputHelper); // Assert Assert.Equal(ExitCodes.Success, result.ExitCode); @@ -76,12 +79,12 @@ await SimpleTestPackageUtility.CreatePackagesAsync( packageZ); string addPackageCommandArgs = $"add {project.ProjectPath} package {packageX.Id}"; - CommandRunnerResult addPackageResult = _testFixture.RunDotnetExpectSuccess(pathContext.SolutionRoot, addPackageCommandArgs); + CommandRunnerResult addPackageResult = _testFixture.RunDotnetExpectSuccess(pathContext.SolutionRoot, addPackageCommandArgs, testOutputHelper: _testOutputHelper); string whyCommandArgs = $"nuget why {project.ProjectPath} {packageZ.Id}"; // Act - CommandRunnerResult result = _testFixture.RunDotnetExpectSuccess(pathContext.SolutionRoot, whyCommandArgs); + CommandRunnerResult result = _testFixture.RunDotnetExpectSuccess(pathContext.SolutionRoot, whyCommandArgs, testOutputHelper: _testOutputHelper); // Assert Assert.Equal(ExitCodes.Success, result.ExitCode); @@ -109,12 +112,12 @@ await SimpleTestPackageUtility.CreatePackagesAsync( packageY); string addPackageCommandArgs = $"add {project.ProjectPath} package {packageX.Id}"; - CommandRunnerResult addPackageResult = _testFixture.RunDotnetExpectSuccess(pathContext.SolutionRoot, addPackageCommandArgs); + CommandRunnerResult addPackageResult = _testFixture.RunDotnetExpectSuccess(pathContext.SolutionRoot, addPackageCommandArgs, testOutputHelper: _testOutputHelper); string whyCommandArgs = $"nuget why {project.ProjectPath} {packageY.Id} --framework {projectFramework}"; // Act - CommandRunnerResult result = _testFixture.RunDotnetExpectSuccess(pathContext.SolutionRoot, whyCommandArgs); + CommandRunnerResult result = _testFixture.RunDotnetExpectSuccess(pathContext.SolutionRoot, whyCommandArgs, testOutputHelper: _testOutputHelper); // Assert Assert.Equal(ExitCodes.Success, result.ExitCode); @@ -142,12 +145,12 @@ await SimpleTestPackageUtility.CreatePackagesAsync( packageY); string addPackageCommandArgs = $"add {project.ProjectPath} package {packageX.Id}"; - CommandRunnerResult addPackageResult = _testFixture.RunDotnetExpectSuccess(pathContext.SolutionRoot, addPackageCommandArgs); + CommandRunnerResult addPackageResult = _testFixture.RunDotnetExpectSuccess(pathContext.SolutionRoot, addPackageCommandArgs, testOutputHelper: _testOutputHelper); string whyCommandArgs = $"nuget why {project.ProjectPath} {packageY.Id} -f {projectFramework}"; // Act - CommandRunnerResult result = _testFixture.RunDotnetExpectSuccess(pathContext.SolutionRoot, whyCommandArgs); + CommandRunnerResult result = _testFixture.RunDotnetExpectSuccess(pathContext.SolutionRoot, whyCommandArgs, testOutputHelper: _testOutputHelper); // Assert Assert.Equal(ExitCodes.Success, result.ExitCode); @@ -163,7 +166,7 @@ public void WhyCommand_EmptyProjectArgument_Fails() string whyCommandArgs = $"nuget why"; // Act - CommandRunnerResult result = _testFixture.RunDotnetExpectFailure(pathContext.SolutionRoot, whyCommandArgs); + CommandRunnerResult result = _testFixture.RunDotnetExpectFailure(pathContext.SolutionRoot, whyCommandArgs, testOutputHelper: _testOutputHelper); // Assert Assert.Equal(ExitCodes.InvalidArguments, result.ExitCode); @@ -181,7 +184,7 @@ public void WhyCommand_EmptyPackageArgument_Fails() string whyCommandArgs = $"nuget why {project.ProjectPath}"; // Act - CommandRunnerResult result = _testFixture.RunDotnetExpectFailure(pathContext.SolutionRoot, whyCommandArgs); + CommandRunnerResult result = _testFixture.RunDotnetExpectFailure(pathContext.SolutionRoot, whyCommandArgs, testOutputHelper: _testOutputHelper); // Assert Assert.Equal(ExitCodes.InvalidArguments, result.ExitCode); @@ -210,12 +213,12 @@ await SimpleTestPackageUtility.CreatePackagesAsync( packageY); string addPackageCommandArgs = $"add {project.ProjectPath} package {packageX.Id}"; - CommandRunnerResult addPackageResult = _testFixture.RunDotnetExpectSuccess(pathContext.SolutionRoot, addPackageCommandArgs); + CommandRunnerResult addPackageResult = _testFixture.RunDotnetExpectSuccess(pathContext.SolutionRoot, addPackageCommandArgs, testOutputHelper: _testOutputHelper); string whyCommandArgs = $"nuget why {project.ProjectPath} {packageY.Id} -f {inputFrameworksOption} -f {projectFramework}"; // Act - CommandRunnerResult result = _testFixture.RunDotnetExpectSuccess(pathContext.SolutionRoot, whyCommandArgs); + CommandRunnerResult result = _testFixture.RunDotnetExpectSuccess(pathContext.SolutionRoot, whyCommandArgs, testOutputHelper: _testOutputHelper); // Assert Assert.Equal(ExitCodes.Success, result.ExitCode); @@ -244,13 +247,13 @@ await SimpleTestPackageUtility.CreatePackagesAsync( packageY); string addPackageCommandArgs = $"add {project.ProjectPath} package {packageX.Id}"; - CommandRunnerResult addPackageResult = _testFixture.RunDotnetExpectSuccess(pathContext.SolutionRoot, addPackageCommandArgs); + CommandRunnerResult addPackageResult = _testFixture.RunDotnetExpectSuccess(pathContext.SolutionRoot, addPackageCommandArgs, testOutputHelper: _testOutputHelper); var projectDirectory = Path.GetDirectoryName(project.ProjectPath); string whyCommandArgs = $"nuget why {projectDirectory} {packageY.Id}"; // Act - CommandRunnerResult result = _testFixture.RunDotnetExpectSuccess(pathContext.SolutionRoot, whyCommandArgs); + CommandRunnerResult result = _testFixture.RunDotnetExpectSuccess(pathContext.SolutionRoot, whyCommandArgs, testOutputHelper: _testOutputHelper); // Assert Assert.Equal(ExitCodes.Success, result.ExitCode); @@ -278,13 +281,13 @@ await SimpleTestPackageUtility.CreatePackagesAsync( packageY); string addPackageCommandArgs = $"add {project.ProjectPath} package {packageX.Id}"; - CommandRunnerResult addPackageResult = _testFixture.RunDotnetExpectSuccess(pathContext.SolutionRoot, addPackageCommandArgs); + CommandRunnerResult addPackageResult = _testFixture.RunDotnetExpectSuccess(pathContext.SolutionRoot, addPackageCommandArgs, testOutputHelper: _testOutputHelper); var assetsFile = Path.Combine(Path.GetDirectoryName(project.ProjectPath), "obj", "project.assets.json"); // Act string whyCommandArgs = $"nuget why {assetsFile} {packageY.Id}"; - CommandRunnerResult result = _testFixture.RunDotnetExpectSuccess(pathContext.SolutionRoot, whyCommandArgs); + CommandRunnerResult result = _testFixture.RunDotnetExpectSuccess(pathContext.SolutionRoot, whyCommandArgs, testOutputHelper: _testOutputHelper); // Assert result.AllOutput.Should().Contain(packageX.Id); @@ -300,7 +303,7 @@ public void WhyCommand_EmptyJsonFile_OutputsError() // Act string whyCommandArgs = $"nuget why {jsonFilePath} packageId"; - CommandRunnerResult result = _testFixture.RunDotnetExpectFailure(testDirectory, whyCommandArgs); + CommandRunnerResult result = _testFixture.RunDotnetExpectFailure(testDirectory, whyCommandArgs, testOutputHelper: _testOutputHelper); // Assert result.AllOutput.Should().Contain("https://aka.ms/dotnet/nuget/why"); From d4fcbe11a6db909faf2723004a284640c646f3f4 Mon Sep 17 00:00:00 2001 From: Jeff Kluge Date: Thu, 9 Jan 2025 12:30:21 -0800 Subject: [PATCH 3/4] Use a constant for project target framework in DotnetWhyTests --- .../Dotnet.Integration.Test/DotnetWhyTests.cs | 72 +++++++++---------- 1 file changed, 32 insertions(+), 40 deletions(-) diff --git a/test/NuGet.Core.FuncTests/Dotnet.Integration.Test/DotnetWhyTests.cs b/test/NuGet.Core.FuncTests/Dotnet.Integration.Test/DotnetWhyTests.cs index f30c769e8e2..2519be13095 100644 --- a/test/NuGet.Core.FuncTests/Dotnet.Integration.Test/DotnetWhyTests.cs +++ b/test/NuGet.Core.FuncTests/Dotnet.Integration.Test/DotnetWhyTests.cs @@ -32,15 +32,14 @@ public async Task WhyCommand_ProjectHasTransitiveDependency_DependencyPathExists { // Arrange var pathContext = new SimpleTestPathContext(); - var projectFramework = "net7.0"; - var project = XPlatTestUtils.CreateProject(ProjectName, pathContext, projectFramework); + var project = XPlatTestUtils.CreateProject(ProjectName, pathContext, Constants.ProjectTargetFramework); - var packageX = XPlatTestUtils.CreatePackage("PackageX", "1.0.0", projectFramework); - var packageY = XPlatTestUtils.CreatePackage("PackageY", "1.0.1", projectFramework); + var packageX = XPlatTestUtils.CreatePackage("PackageX", "1.0.0", Constants.ProjectTargetFramework); + var packageY = XPlatTestUtils.CreatePackage("PackageY", "1.0.1", Constants.ProjectTargetFramework); packageX.Dependencies.Add(packageY); - project.AddPackageToFramework(projectFramework, packageX); + project.AddPackageToFramework(Constants.ProjectTargetFramework, packageX); await SimpleTestPackageUtility.CreatePackagesAsync( pathContext.PackageSource, @@ -65,13 +64,12 @@ public async Task WhyCommand_ProjectHasNoDependencyOnTargetPackage_PathDoesNotEx { // Arrange var pathContext = new SimpleTestPathContext(); - var projectFramework = "net7.0"; - var project = XPlatTestUtils.CreateProject(ProjectName, pathContext, projectFramework); + var project = XPlatTestUtils.CreateProject(ProjectName, pathContext, Constants.ProjectTargetFramework); - var packageX = XPlatTestUtils.CreatePackage("PackageX", "1.0.0", projectFramework); - project.AddPackageToFramework(projectFramework, packageX); + var packageX = XPlatTestUtils.CreatePackage("PackageX", "1.0.0", Constants.ProjectTargetFramework); + project.AddPackageToFramework(Constants.ProjectTargetFramework, packageX); - var packageZ = XPlatTestUtils.CreatePackage("PackageZ", "1.0.0", projectFramework); + var packageZ = XPlatTestUtils.CreatePackage("PackageZ", "1.0.0", Constants.ProjectTargetFramework); await SimpleTestPackageUtility.CreatePackagesAsync( pathContext.PackageSource, @@ -96,15 +94,14 @@ public async Task WhyCommand_WithFrameworksOption_OptionParsedSuccessfully() { // Arrange var pathContext = new SimpleTestPathContext(); - var projectFramework = "net7.0"; - var project = XPlatTestUtils.CreateProject(ProjectName, pathContext, projectFramework); + var project = XPlatTestUtils.CreateProject(ProjectName, pathContext, Constants.ProjectTargetFramework); - var packageX = XPlatTestUtils.CreatePackage("PackageX", "1.0.0", projectFramework); - var packageY = XPlatTestUtils.CreatePackage("PackageY", "1.0.1", projectFramework); + var packageX = XPlatTestUtils.CreatePackage("PackageX", "1.0.0", Constants.ProjectTargetFramework); + var packageY = XPlatTestUtils.CreatePackage("PackageY", "1.0.1", Constants.ProjectTargetFramework); packageX.Dependencies.Add(packageY); - project.AddPackageToFramework(projectFramework, packageX); + project.AddPackageToFramework(Constants.ProjectTargetFramework, packageX); await SimpleTestPackageUtility.CreatePackagesAsync( pathContext.PackageSource, @@ -114,7 +111,7 @@ await SimpleTestPackageUtility.CreatePackagesAsync( string addPackageCommandArgs = $"add {project.ProjectPath} package {packageX.Id}"; CommandRunnerResult addPackageResult = _testFixture.RunDotnetExpectSuccess(pathContext.SolutionRoot, addPackageCommandArgs, testOutputHelper: _testOutputHelper); - string whyCommandArgs = $"nuget why {project.ProjectPath} {packageY.Id} --framework {projectFramework}"; + string whyCommandArgs = $"nuget why {project.ProjectPath} {packageY.Id} --framework {Constants.ProjectTargetFramework}"; // Act CommandRunnerResult result = _testFixture.RunDotnetExpectSuccess(pathContext.SolutionRoot, whyCommandArgs, testOutputHelper: _testOutputHelper); @@ -129,15 +126,14 @@ public async Task WhyCommand_WithFrameworksOptionAlias_OptionParsedSuccessfully( { // Arrange var pathContext = new SimpleTestPathContext(); - var projectFramework = "net7.0"; - var project = XPlatTestUtils.CreateProject(ProjectName, pathContext, projectFramework); + var project = XPlatTestUtils.CreateProject(ProjectName, pathContext, Constants.ProjectTargetFramework); - var packageX = XPlatTestUtils.CreatePackage("PackageX", "1.0.0", projectFramework); - var packageY = XPlatTestUtils.CreatePackage("PackageY", "1.0.1", projectFramework); + var packageX = XPlatTestUtils.CreatePackage("PackageX", "1.0.0", Constants.ProjectTargetFramework); + var packageY = XPlatTestUtils.CreatePackage("PackageY", "1.0.1", Constants.ProjectTargetFramework); packageX.Dependencies.Add(packageY); - project.AddPackageToFramework(projectFramework, packageX); + project.AddPackageToFramework(Constants.ProjectTargetFramework, packageX); await SimpleTestPackageUtility.CreatePackagesAsync( pathContext.PackageSource, @@ -147,7 +143,7 @@ await SimpleTestPackageUtility.CreatePackagesAsync( string addPackageCommandArgs = $"add {project.ProjectPath} package {packageX.Id}"; CommandRunnerResult addPackageResult = _testFixture.RunDotnetExpectSuccess(pathContext.SolutionRoot, addPackageCommandArgs, testOutputHelper: _testOutputHelper); - string whyCommandArgs = $"nuget why {project.ProjectPath} {packageY.Id} -f {projectFramework}"; + string whyCommandArgs = $"nuget why {project.ProjectPath} {packageY.Id} -f {Constants.ProjectTargetFramework}"; // Act CommandRunnerResult result = _testFixture.RunDotnetExpectSuccess(pathContext.SolutionRoot, whyCommandArgs, testOutputHelper: _testOutputHelper); @@ -178,8 +174,7 @@ public void WhyCommand_EmptyPackageArgument_Fails() { // Arrange var pathContext = new SimpleTestPathContext(); - var projectFramework = "net7.0"; - var project = XPlatTestUtils.CreateProject(ProjectName, pathContext, projectFramework); + var project = XPlatTestUtils.CreateProject(ProjectName, pathContext, Constants.ProjectTargetFramework); string whyCommandArgs = $"nuget why {project.ProjectPath}"; @@ -196,16 +191,15 @@ public async Task WhyCommand_InvalidFrameworksOption_WarnsCorrectly() { // Arrange var pathContext = new SimpleTestPathContext(); - var projectFramework = "net7.0"; var inputFrameworksOption = "invalidFrameworkAlias"; - var project = XPlatTestUtils.CreateProject(ProjectName, pathContext, projectFramework); + var project = XPlatTestUtils.CreateProject(ProjectName, pathContext, Constants.ProjectTargetFramework); - var packageX = XPlatTestUtils.CreatePackage("PackageX", "1.0.0", projectFramework); - var packageY = XPlatTestUtils.CreatePackage("PackageY", "1.0.1", projectFramework); + var packageX = XPlatTestUtils.CreatePackage("PackageX", "1.0.0", Constants.ProjectTargetFramework); + var packageY = XPlatTestUtils.CreatePackage("PackageY", "1.0.1", Constants.ProjectTargetFramework); packageX.Dependencies.Add(packageY); - project.AddPackageToFramework(projectFramework, packageX); + project.AddPackageToFramework(Constants.ProjectTargetFramework, packageX); await SimpleTestPackageUtility.CreatePackagesAsync( pathContext.PackageSource, @@ -215,7 +209,7 @@ await SimpleTestPackageUtility.CreatePackagesAsync( string addPackageCommandArgs = $"add {project.ProjectPath} package {packageX.Id}"; CommandRunnerResult addPackageResult = _testFixture.RunDotnetExpectSuccess(pathContext.SolutionRoot, addPackageCommandArgs, testOutputHelper: _testOutputHelper); - string whyCommandArgs = $"nuget why {project.ProjectPath} {packageY.Id} -f {inputFrameworksOption} -f {projectFramework}"; + string whyCommandArgs = $"nuget why {project.ProjectPath} {packageY.Id} -f {inputFrameworksOption} -f {Constants.ProjectTargetFramework}"; // Act CommandRunnerResult result = _testFixture.RunDotnetExpectSuccess(pathContext.SolutionRoot, whyCommandArgs, testOutputHelper: _testOutputHelper); @@ -231,15 +225,14 @@ public async Task WhyCommand_DirectoryWithProject_HasTransitiveDependency_Depend { // Arrange var pathContext = new SimpleTestPathContext(); - var projectFramework = "net7.0"; - var project = XPlatTestUtils.CreateProject(ProjectName, pathContext, projectFramework); + var project = XPlatTestUtils.CreateProject(ProjectName, pathContext, Constants.ProjectTargetFramework); - var packageX = XPlatTestUtils.CreatePackage("PackageX", "1.0.0", projectFramework); - var packageY = XPlatTestUtils.CreatePackage("PackageY", "1.0.1", projectFramework); + var packageX = XPlatTestUtils.CreatePackage("PackageX", "1.0.0", Constants.ProjectTargetFramework); + var packageY = XPlatTestUtils.CreatePackage("PackageY", "1.0.1", Constants.ProjectTargetFramework); packageX.Dependencies.Add(packageY); - project.AddPackageToFramework(projectFramework, packageX); + project.AddPackageToFramework(Constants.ProjectTargetFramework, packageX); await SimpleTestPackageUtility.CreatePackagesAsync( pathContext.PackageSource, @@ -265,15 +258,14 @@ public async Task WhyCommand_AssetsFileWithoutProject_Succeeds() { // Arrange var pathContext = new SimpleTestPathContext(); - var projectFramework = "net7.0"; - var project = XPlatTestUtils.CreateProject(ProjectName, pathContext, projectFramework); + var project = XPlatTestUtils.CreateProject(ProjectName, pathContext, Constants.ProjectTargetFramework); - var packageX = XPlatTestUtils.CreatePackage("PackageX", "1.0.0", projectFramework); - var packageY = XPlatTestUtils.CreatePackage("PackageY", "1.0.1", projectFramework); + var packageX = XPlatTestUtils.CreatePackage("PackageX", "1.0.0", Constants.ProjectTargetFramework); + var packageY = XPlatTestUtils.CreatePackage("PackageY", "1.0.1", Constants.ProjectTargetFramework); packageX.Dependencies.Add(packageY); - project.AddPackageToFramework(projectFramework, packageX); + project.AddPackageToFramework(Constants.ProjectTargetFramework, packageX); await SimpleTestPackageUtility.CreatePackagesAsync( pathContext.PackageSource, From 53867f622abe3a9a5e8f35dc8decf5bb6ea97111 Mon Sep 17 00:00:00 2001 From: Jeff Kluge Date: Thu, 9 Jan 2025 12:30:42 -0800 Subject: [PATCH 4/4] Disable WhyCommand_EmptyPackageArgument_Fails --- .../Dotnet.Integration.Test/DotnetWhyTests.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/NuGet.Core.FuncTests/Dotnet.Integration.Test/DotnetWhyTests.cs b/test/NuGet.Core.FuncTests/Dotnet.Integration.Test/DotnetWhyTests.cs index 2519be13095..8738430a195 100644 --- a/test/NuGet.Core.FuncTests/Dotnet.Integration.Test/DotnetWhyTests.cs +++ b/test/NuGet.Core.FuncTests/Dotnet.Integration.Test/DotnetWhyTests.cs @@ -169,7 +169,7 @@ public void WhyCommand_EmptyProjectArgument_Fails() Assert.Contains($"Required argument missing for command: 'why'.", result.Errors); } - [Fact] + [Fact(Skip = "https://github.com/NuGet/Home/issues/14030")] public void WhyCommand_EmptyPackageArgument_Fails() { // Arrange