Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to version 18.0 #207

Open
4 of 12 tasks
OCA-git-bot opened this issue Oct 6, 2024 · 7 comments
Open
4 of 12 tasks

Migration to version 18.0 #207

OCA-git-bot opened this issue Oct 6, 2024 · 7 comments
Labels
help wanted no stale Use this label to prevent the automated stale action from closing this PR/Issue. work in progress
Milestone

Comments

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Oct 6, 2024

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0

Modules to migrate

Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list

@OCA-git-bot OCA-git-bot added help wanted no stale Use this label to prevent the automated stale action from closing this PR/Issue. work in progress labels Oct 6, 2024
@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Oct 6, 2024
@xaviedoanhduy
Copy link

l10n_eu_product_adr_dangerous_goods: #211

@LucasTran380381
Copy link

account_tax_unece #215

@achulii
Copy link

achulii commented Nov 19, 2024

base_bank_from_iban #217

@achulii
Copy link

achulii commented Nov 25, 2024

l10n_eu_nace #218

@alexis-via
Copy link
Contributor

I was wondering if it's a good idea to continue to maintain uom_unece in Odoo because, since v17, the account module has a method _get_unece_code() on uom.uom, cf https://github.com/odoo/odoo/blob/18.0/addons/account/models/uom_uom.py#L17 (this method was part of account_edi from v14 to v16).

This method works to get the UNECE code from an uom. First drawback: when you manually add a unit of measure in Odoo, you have to inherit the method _get_unece_code() to set the corresponding UNECE code.
But, for me, the major drawback of adopting the code in the account module is that, when you import an order/invoice, you need to find the uom from the UNECE code, and I don't see how you can do that with the code of the account module (without writing horrible code that loops to every uom to get the corresponding UNECE code and then match... too dirty).

So my conclusion is that we should continue to use uom_unece. Do you have the same opinion ?

@pedrobaeza
Copy link
Member

Yes, I agree.

@ClemRiviere
Copy link

base_iso3166 #220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted no stale Use this label to prevent the automated stale action from closing this PR/Issue. work in progress
Projects
None yet
Development

No branches or pull requests

7 participants