Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] partner_industry_secondary: make industry readable #1954

Open
rafaelbn opened this issue Jan 9, 2025 · 7 comments
Open

[16.0][IMP] partner_industry_secondary: make industry readable #1954

rafaelbn opened this issue Jan 9, 2025 · 7 comments
Milestone

Comments

@rafaelbn
Copy link
Member

rafaelbn commented Jan 9, 2025

Is your feature request related to a problem?

Yes. When assigning industries to companies (res.partner), the entire hierarchy is displayed, making the field unreadable and cluttered. Users cannot easily identify the assigned industry.

https://www.loom.com/share/1c855ba941e6414392e60509f47dbb9d?sid=2c49896e-92d7-4f06-8fc4-cde7827a0628

Describe the solution you'd like

Display only the selected industry in the res.partner form, without showing the full hierarchy. This simplifies the interface and improves readability.

Describe alternatives you've considered

  • Showing the full hierarchy as a breadcrumb (e.g., Parent Industry > Child Industry), but this still adds unnecessary complexity.
  • Allowing users to toggle the display, which complicates the implementation.

Additional context

This change aligns with the principle "less is more" by prioritizing simplicity and clarity for the user.

MT-8595 @moduon

@rafaelbn rafaelbn added this to the 16.0 milestone Jan 9, 2025
@pedrobaeza
Copy link
Member

I don't agree with this change. There can be several industries with the same name in different leafs, and you need to differentiate them.

@rafaelbn
Copy link
Member Author

rafaelbn commented Jan 9, 2025

Thank you for your input! Ultimately, UX decisions should be guided by how users experience the system, not just by data structures. Displaying the full hierarchy sacrifices clarity for most users.

Would you be open to gathering feedback from actual users to better inform this decision?

Design for humans

😄

@pedrobaeza
Copy link
Member

What I state is also UX

@rafaelbn
Copy link
Member Author

rafaelbn commented Jan 9, 2025

OK, could we have more opinions from @OCA/crm-sales-marketing-maintainers ?

I show it in 1 minutes in this video: https://www.loom.com/share/1c855ba941e6414392e60509f47dbb9d?sid=7dfffc32-1663-4ac1-81d7-8ad624282738

What I state is also UX

Obviously. But what you state is not the users experience. Is your opinion about UX. Let's see if there are more opinions about this matter ❤️ . My proposal don't come from me, come from several and repeated request about this features in our clients 😃

@simahawk
Copy link
Contributor

What about making it optional? You can have a setting the company and control how you display the name.
You make this easy to hook and add the new feature in the same module or in a second optional module.

@Shide
Copy link
Contributor

Shide commented Jan 10, 2025

What about making it optional? You can have a setting the company and control how you display the name. You make this easy to hook and add the new feature in the same module or in a second optional module.

I'm ok with this setting to all companies.

Considerations:

If you found a duplicate and the results are not higher than the m2m dropdown (8 by default), the "Search More" button doesn't appear and we don't know what Sector we must choose. (See below)
image

A solution that shows some information about the parents:

To have a "little" better understanding of what sector we are choosing, we can do as Linux terminal does (fish terminal for example): Show the first letter of the parent paths and display the last element entirely:
image

In Odoo will look like this:

Sectors without parents:
image

With 1 char:
image

With 2 chars:
image

With 3 chars:
image

We don't know exactly the parent element, but we know that one sector has another parent.

I suggest the "1 char" option, because if the name it's exactly the same, the parent will be the same or almost the same and the first word it's not going to change a lot, so the information shown it's the same, but large.

What do you think?

@yajo
Copy link
Member

yajo commented Jan 10, 2025

IMHO the simplest solution is to put most important stuff first.

Right now we display industries like "Ancestor / Grampa / Dad / Child", which trims it to "Ancestor / Grampa / ..." and leaves most important info out of sight.

Instead, we could have "Child (Dad < Grampa < Ancestor)". Odoo would trim it to "Child (Dad < Gram..." letting you see the most important information directly, but still letting you use "Search more" to see more details.

Mockups:

image
image

This system wouldn't help for sorting, though. But I think the trade-off is worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants