Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0] Branch tests are broken #734

Closed
bosd opened this issue Oct 23, 2023 · 1 comment
Closed

[15.0] Branch tests are broken #734

bosd opened this issue Oct 23, 2023 · 1 comment
Labels

Comments

@bosd
Copy link
Contributor

bosd commented Oct 23, 2023

Branch tests are broken
as dicovered in: #732 (comment)

2023-10-22 21:15:40,673 1031 ERROR odoo odoo.addons.base_tier_validation_forward.tests.test_tier_validation: ERROR: TierTierValidation.test_01_forward_tier
Traceback (most recent call last):
  File "/__w/server-ux/server-ux/base_tier_validation_forward/tests/test_tier_validation.py", line 98, in test_01_forward_tier
    wizard = Form(
  File "/opt/odoo/odoo/tests/common.py", line 1957, in __init__
    self._init_from_defaults(self._model)
  File "/opt/odoo/odoo/tests/common.py", line 2039, in _init_from_defaults
    self._perform_onchange([])
  File "/opt/odoo/odoo/tests/common.py", line 2325, in _perform_onchange
    result = record.onchange(self._onchange_values(), fields, spec)
  File "/opt/odoo/odoo/models.py", line 6255, in onchange
    self.flush()
  File "/opt/odoo/odoo/models.py", line 5672, in flush
    self.recompute()
  File "/opt/odoo/odoo/models.py", line 6145, in recompute
    process(field)
  File "/opt/odoo/odoo/models.py", line 6129, in process
    field.recompute(recs)
  File "/opt/odoo/odoo/fields.py", line 1268, in recompute
    self.compute_value(recs)
  File "/opt/odoo/odoo/fields.py", line 1290, in compute_value
    records._compute_field_value(self)
  File "/opt/odoo/odoo/models.py", line 4269, in _compute_field_value
    fields.determine(field.compute, self)
  File "/opt/odoo/odoo/fields.py", line 87, in determine
    return needle(*args)
  File "/__w/server-ux/server-ux/base_tier_validation_report/models/tier_review.py", line 38, in _compute_resource_ref
    rec.resource_ref = (
  File "/opt/odoo/odoo/fields.py", line 1222, in __set__
    self.write(protected_records, value)
  File "/opt/odoo/odoo/fields.py", line 1040, in write
    cache_value = self.convert_to_cache(value, records)
  File "/opt/odoo/odoo/fields.py", line 2587, in convert_to_cache
    raise ValueError("Wrong value for %s: %r" % (self, value))
ValueError: Wrong value for tier.review.resource_ref: 'tier.validation.tester,2'
 

The same test was passing before. Something has probably changed somewhere else.

Module

base_tier_validation_report

attempted to fix it in: #733
But it is a hard one, as I cannot reproduce it locally.

Somebody here to the rescue?? 🙏

@LoisRForgeFlow
Copy link
Contributor

Branch 15.0 CI has been fixed in #737. You can rebase your open PRs to fix issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants