Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] hr_employee_cost_history: add a comment field #696

Open
sbidoul opened this issue Jun 24, 2024 · 5 comments
Open

[RFC] hr_employee_cost_history: add a comment field #696

sbidoul opened this issue Jun 24, 2024 · 5 comments
Labels
enhancement stale PR/Issue without recent activity, it'll be soon closed automatically.

Comments

@sbidoul
Copy link
Member

sbidoul commented Jun 24, 2024

Thanks for the hr_employee_cost_history module.

Would it make sense to add a comment field on history line?
The use case is to document the reason for the change (salary raise, automatic indexation, etc).

If you agree, we can do a PR.

@rafaelbn @edlopen

@alexey-pelykh
Copy link
Contributor

Should that be an HR contract or some paperwork attached?

@sbidoul
Copy link
Member Author

sbidoul commented Jun 24, 2024

Should that be an HR contract or some paperwork attached?

Not necessarily. For instance in Belgium & Luxemburg there is an automatic salary indexation mechanism without any contractual change.

@edlopen
Copy link
Member

edlopen commented Jun 24, 2024

It makes sense indeed. Ping me in your PR to review it! Thank you!

@rafaelbn
Copy link
Member

I'll test it too @sbidoul 👍🏼

Copy link

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

No branches or pull requests

4 participants