diff --git a/src/util-logopenfile.c b/src/util-logopenfile.c index feca63f44afd..6f272bca6530 100644 --- a/src/util-logopenfile.c +++ b/src/util-logopenfile.c @@ -347,14 +347,17 @@ static void ThreadLogFileHashFreeFunc(void *data) BUG_ON(data == NULL); ThreadLogFileHashEntry *thread_ent = (ThreadLogFileHashEntry *)data; - if (thread_ent) { + if (!thread_ent) + return; + + if (thread_ent->isopen) { LogFileCtx *lf_ctx = thread_ent->ctx; /* Free the leaf log file entries */ if (!lf_ctx->threaded) { LogFileFreeCtx(lf_ctx); } - SCFree(thread_ent); } + SCFree(thread_ent); } bool SCLogOpenThreadedFile(const char *log_path, const char *append, LogFileCtx *parent_ctx) @@ -711,6 +714,7 @@ LogFileCtx *LogFileEnsureExists(LogFileCtx *parent_ctx) if (!parent_ctx->threaded) return parent_ctx; + LogFileCtx *ret_ctx = NULL; SCMutexLock(&parent_ctx->threads->mutex); /* Find this thread's entry */ ThreadLogFileHashEntry *entry = LogFileThread2Slot(parent_ctx->threads); @@ -719,17 +723,20 @@ LogFileCtx *LogFileEnsureExists(LogFileCtx *parent_ctx) bool new = entry->isopen; /* has it been opened yet? */ - if (!entry->isopen) { - SCLogDebug("Opening new file for thread/slot %d to file %s [ctx %p]", entry->slot_number, - parent_ctx->filename, parent_ctx); + if (!new) { + SCLogDebug("%s: Opening new file for thread/id %ld to file %s [ctx %p]", t_thread_name, + SCGetThreadIdLong(), parent_ctx->filename, parent_ctx); if (LogFileNewThreadedCtx( parent_ctx, parent_ctx->filename, parent_ctx->threads->append, entry)) { entry->isopen = true; + ret_ctx = entry->ctx; } else { - SCLogError( + SCLogDebug( "Unable to open slot %d for file %s", entry->slot_number, parent_ctx->filename); (void)HashTableRemove(parent_ctx->threads->ht, entry, 0); } + } else { + ret_ctx = entry->ctx; } SCMutexUnlock(&parent_ctx->threads->mutex); @@ -740,7 +747,7 @@ LogFileCtx *LogFileEnsureExists(LogFileCtx *parent_ctx) } } - return entry->ctx; + return ret_ctx; } /** \brief LogFileThreadedName() Create file name for threaded EVE storage