Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPT-170-Tenderer is mandatory even if there is no tenderer #1124

Open
GarrusMD opened this issue Jan 29, 2025 · 4 comments
Open

OPT-170-Tenderer is mandatory even if there is no tenderer #1124

GarrusMD opened this issue Jan 29, 2025 · 4 comments
Assignees
Labels
schematrons Related to the Schematron validation (/schematrons SDK folder)
Milestone

Comments

@GarrusMD
Copy link

The fields.json states that the OPT-170-Tenderer field is mandatory if there is not equal to 1 tenderer. This means that the field is even mandatory if there is no tenderer at all. Please change the rule so that the field only becomes mandatory if there are at least 2 tenderers.

@YvesJo
Copy link
Contributor

YvesJo commented Jan 29, 2025

The context for the rule is the parent node ND-Tenderer which only contains OPT-170-Tenderer and OPT-300-Tenderer.
Empty nodes aren't also allowed, therefore in absence of OPT-170-Tenderer and OPT-300-Tenderer, ND-Tenderer shouldn't be present in the XML and the CM rule won't get triggered (i.e. OPT-170-Tenderer is not mandatory).
May be what is meant is that the UI is not able to deal with the rules context properly and a solution would be to update the current condition so that the field won't appear as mandatory?

@YvesJo YvesJo added the schematrons Related to the Schematron validation (/schematrons SDK folder) label Jan 29, 2025
@YvesJo YvesJo self-assigned this Jan 29, 2025
@GarrusMD
Copy link
Author

Correct. The current rules lead to strange side effects when entering the data.

Because the OPT-300-Tenderer field only appears after several preconditions have been met, only the ‘OPT-170-Tenderer’ field is initially displayed (as a mandatory field). Even after the preconditions have been fulfilled and OPT-300-Tenderer is displayed, it is irritating for the person entering the data that OPT-170-Tenderer is displayed as a mandatory field until OPT-300-Tenderer has been filled in.

Is there any reason why OPT-170-Tenderer should not be displayed until there are at least two tenderers?

@YvesJo
Copy link
Contributor

YvesJo commented Jan 30, 2025

Indeed, business wise, the indicator used to specify that a tenderer is a group leader is useless until at least 2 organizations have been identified.
Develop a UI able to deal with the various rules and their context may be quite challenging and not have a great ROI and the proposed rule update is certainly the best option, therefore I will update this with the next SDK.
KR

@YvesJo YvesJo added this to the SDK 1.14.0 milestone Jan 30, 2025
@GarrusMD
Copy link
Author

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
schematrons Related to the Schematron validation (/schematrons SDK folder)
Projects
None yet
Development

No branches or pull requests

2 participants