Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression in Node AccessRestrictions: change return type from uint32 to ushort #2883

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Fix regression in Node AccessRestrictions: change return type from uint32 to ushort #2883

merged 1 commit into from
Dec 5, 2024

Conversation

romanett
Copy link
Contributor

@romanett romanett commented Dec 4, 2024 •
edited by mregen
Loading

Proposed changes

Cast the AccessRestrictions explicitly to ushort to conform to spec (regression from 1.05.03. Nodeset update).

See also 1e927dd

Related Issues

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

@romanett romanett added the bug A bug was identified and should be fixed. label Dec 4, 2024
@romanett romanett requested a review from mregen December 4, 2024 20:11
@romanett romanett self-assigned this Dec 4, 2024
@romanett romanett linked an issue Dec 4, 2024 that may be closed by this pull request
Inconsistent data type for AccessRestrictions #2870
Open
5 tasks
@mregen mregen merged commit 67a0df1 into OPCFoundation:develop/main374 Dec 5, 2024
48 checks passed
@romanett romanett deleted the fixAcessRestrictions branch January 13, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mregen mregen mregen approved these changes

Assignees

@romanett romanett

Labels
bug A bug was identified and should be fixed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent data type for AccessRestrictions
2 participants
@romanett @mregen