Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show the actual tags that will be applied #255

Open
thibaultmol opened this issue Mar 25, 2024 · 10 comments
Open

show the actual tags that will be applied #255

thibaultmol opened this issue Mar 25, 2024 · 10 comments
Labels
feature request New feature request

Comments

@thibaultmol
Copy link

Idea

It might be good for people who actually know whatt osm is if there was an option in the settings to show the actual tag(s) that will be applied depending on your answer.

Bug Relation

No response

Implementation

No response

Additional Info

No response

@thibaultmol thibaultmol added the feature request New feature request label Mar 25, 2024
@rugk
Copy link

rugk commented Mar 27, 2024

IMHO rather an advanced feature and I like how StreetComplete solves it to only show this in the "revert dialog", which would be a new feature for this app, too.

@thibaultmol
Copy link
Author

Is it that advanced, though? The app already has to apply the tags anyway, it could just show them? that's how Mapcomplete does it:
image

It even has a link to the wiki page for each key/tag but that's also easy to do because it's just a url template:
https://wiki.openstreetmap.org/wiki/Tag:bench%3Dyes

@rugk
Copy link

rugk commented Mar 27, 2024

Yeah, StreetComplete has in the past refrained from that, because it would just confuse a typical user (as they do not even [have to] know OSM or so), so depending on your target audience, I'd also argue this is similar here.
Also on smartphones there is limited space and if you want to modify multiple tags it gets more etc. etc. SC has reasons not to show it (could not find a fitting issue in their repo right now though).

@thibaultmol
Copy link
Author

I somewhat get it. But on other hand I'm like: it's just one or two lines of text.

Here's how mapcomplete does it on mobile (and that's even with the mode on that shows all questions at once which isn't the default setting for mapcomplete
Screenshot_20240331-085931

@rugk
Copy link

rugk commented May 8, 2024

Yeah, sure, but I TBH Mapcomplete is not really an example of great UX, IMHO. Anyway, sure, do it by all means, maybe hide it behind an (i) icon or so, there are likely more ideas or so, I just wanted to bring in some arguments of why this may not be the most important idea or one which also had some disadvantages.

@1231231231231231231231231

The limited screen space is a valid concern, also because people shouldn't be overwhelmed when this is aimed at an even more general audience than StreetComplete already is.

On the other hand, one of my main annoyances in StreetComplete (second to map rotation constantly triggering when trying to zoom) is that I can't easily see what tags it sets. This is better nowadays with the undo feature showing the tags at least, but it's a workaround more than a solution because you have to pick one of the solutions and then go back to see what you've actually done (and make sure to have auto-upload disabled).

To preserve screen space and visual clutter, could it be something you can fold out? Or if you long press the answer box or options, it will expand or so? It can tell users this is possible in the settings screen for example, then advanced users can find it and new users are not bothered with it

@7h30n3
Copy link
Member

7h30n3 commented Sep 30, 2024

This seems quite an controversal topic, but we want to elaborate on this.
We have some possible solutions in mind, but need feedback from you on which way to go.

The first idea was to just show the tag below the corresponding entry on the summery screen. However not every answer shown there gets acutally written in the changeset. For example, if you answer "Is there a kerb?" with "Yes" (kerb=yes) and later "Is the kerb raised?" also with "Yes" (kerb=raised), only the last tag will be written dispite both answers are shown on the summery screen.
Of course, the "unwritten" tag can just be grayed out.

The second idea was to make it more sophisticated. To get a real benefit from this you not only want to know what new tags will be added, but also what are the current tags. So you can make a qualified descision, if it's all correct.
This means a possible approach could be to show all tags and only the tags. Each tag will be in one of 4 separate "boxes" (unmodified, added, deleted, modified value), to make them easily and quickly distinquishable.

We thought about adding the switch to toggle between the default and the expert view on the summary sheet and not in the settings menu. The toogle would not be persistent, so you always have to click on that button to switch views, because we think the feature/ expert view should only be necessary in rare occasions.

What's your opionion on that?

@thibaultmol
Copy link
Author

I think the 1st option is fine. if people want more, they can open osm directly

@1231231231231231231231231

So you can make a qualified descision, if it's all correct.

This is why the second solution would have my preference.

Instead of needing to use "boxes", a format like what git diff shows seems fairly standardised (removed lines in red with a - prefixed, added lines in green with a + prefixed). Looking into how red-green colour-blind people handle that, since that is the majority of all color-blind people (8% of men), people suggest either shifting the red a bit to orange and the green a bit to cyan, or creating a difference in shading. I found a red-green color-blind person saying that GitHub's red/green diffs work for them so I checked and the green is a lot more saturated than the red. Perhaps that creates a visible-to-everyone shading effect; I'm not sure

The toogle would not be persistent, so you always have to click on that button to switch views, because we think the feature/ expert view should only be necessary in rare occasions

It not not being necessary sounds like a good principle

If that view toggle is presented every time you make a change, that also makes it more visible to everyone and invites people to look at how OSM works with the underlying tags. I would not be opposed to that at all: simple by default, expert view a tap away. Helps people learn how to do the same in other editors as well

I don't think I'd mind doing a single extra tap, even if I would do it most times, especially as compared to StreetComplete where you need to do a number of taps across the screen to apply a proposed change, then get to the undo menu and view the changed tags

@rugk
Copy link

rugk commented Sep 30, 2024

Yeah v1 would be fine for me. If you want v2 then maybe an "expansion" button (cf this older material design; also in Angular) at the bottom or so could help? Or, as you currently kinda have, a bottom sheet, but you can drag it out further to see more details… (more about that here)

I agree some colored diff with red/green for added/removed would be good. For related art, maybe one should look into how the OSM editor Everydoor shows it.
But in any case, one should not be overwhelmed with that, so keep it as simple as possible (or hidden as indicated) and only offer it as some insight if it is wanted.

These are just some visual ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature request
Projects
None yet
Development

No branches or pull requests

4 participants