Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide forward declarations of GDAL types in gdal_fwd.h #11611

Closed
hobu opened this issue Jan 8, 2025 · 1 comment · Fixed by #11613
Closed

Provide forward declarations of GDAL types in gdal_fwd.h #11611

hobu opened this issue Jan 8, 2025 · 1 comment · Fixed by #11613
Assignees
@rouault
Labels
enhancement
Milestone
3.11.0

Comments

@hobu
Copy link
Contributor

hobu commented Jan 8, 2025

Feature description

GDAL should provide forward declarations of its types in gdal_fwd.h if it is to be changing their definitions based on build configuration.

Additional context

The changes in #11314 exposed the fact that PDAL was forward declaring the GDAL objects it used in its public headers. Maybe it shouldn't be doing that, but GDAL was missing forward declarations it could simply #include. This didn't matter until #11314 started changing the definition based on build configuration. Now that GDAL is doing that, it should provide public forward declarations.
@rouault rouault added this to the 3.11.0 milestone Jan 8, 2025
@rouault rouault self-assigned this Jan 8, 2025
rouault added a commit to rouault/gdal that referenced this issue Jan 8, 2025
@rouault
Add a gdal_fwd.h public header with forward definitions of GDAL/OGR/O…
9079fbd 
…SR C opaque types

Fixes OSGeo#11611
@rouault rouault mentioned this issue Jan 8, 2025
Merged
rouault added a commit to rouault/gdal that referenced this issue Jan 8, 2025
@rouault
Add a gdal_fwd.h public header with forward definitions of GDAL/OGR/O…
ffb48ba 
…SR C opaque types

Fixes OSGeo#11611
rouault added a commit to rouault/gdal that referenced this issue Jan 8, 2025
@rouault
Add a gdal_fwd.h public header with forward definitions of GDAL/OGR/O…
8d5e268 
…SR C opaque types

Fixes OSGeo#11611
rouault added a commit to rouault/gdal that referenced this issue Jan 8, 2025
@rouault
Add a gdal_fwd.h public header with forward definitions of GDAL/OGR/O…
9165d62 
…SR C opaque types

Fixes OSGeo#11611
rouault added a commit to rouault/gdal that referenced this issue Jan 8, 2025
@rouault
Add a gdal_fwd.h public header with forward definitions of GDAL/OGR/O…
83b449b 
…SR C opaque types

Fixes OSGeo#11611
@hobu
Copy link
Contributor Author

hobu commented Jan 8, 2025

Addressed in PDAL at PDAL/PDAL#4608

@rouault rouault closed this as completed in b5389d2 Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rouault rouault

Labels
enhancement
Projects
None yet
Milestone
3.11.0
Development

Successfully merging a pull request may close this issue.

Add a gdal_fwd.h public header with forward definitions of GDAL/OGR/OSR C opaque types rouault/gdal
2 participants
@hobu @rouault