Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid tag modification for conversions to multipolygons #355

Open
dieterdreist opened this issue May 15, 2019 · 3 comments
Open

Invalid tag modification for conversions to multipolygons #355

dieterdreist opened this issue May 15, 2019 · 3 comments

Comments

@dieterdreist
Copy link

I'm submitting a bug report

Brief Description

If you remove tags from an area because you create a multipolygon with these tags, osmcha flags it as "invalid tag modification"

What is the motivation / use case for this action?

There are multiple possible reasons for creating multipolygons from area, usually because you have to split a way, add a hole or separate perimeter from the area

What is the current behaviour, (attach relevant screenshots) ?

flags it as "invalid tag modification"

What is the expected behaviour ?

does not flag it

When does this occur ?

always in this context (see above)

How do we replicate the issue ?

Please tell us about your environment:

Other Information / context:

@blackboxlogic
Copy link

blackboxlogic commented Jun 7, 2020

Same exact issue when you remove tags from a node, and incorporate that node is a closed way (which has the tags from the node). For example, converting a node address into a building.
See Node 367794721 in Change 86292360.

And I would say the same fix should be applied to the warning "Deleted a wikidata/wikipedia tag" when that whole element (and its tags) were being merged into something else. See Node 367794682 in Change 86292360.

@dieterdreist
Copy link
Author

I can confirm this is still the case

@tsmock
Copy link

tsmock commented May 17, 2022

Base bug: mapbox/osm-compare#147
Possibly dead PR to fix this: mapbox/osm-compare#149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants