Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect order of text in TAG CHANGES report #606

Open
iriman opened this issue Dec 17, 2021 · 1 comment
Open

Incorrect order of text in TAG CHANGES report #606

iriman opened this issue Dec 17, 2021 · 1 comment

Comments

@iriman
Copy link

iriman commented Dec 17, 2021

I'm submitting a (bug report)

Brief Description

image
From the Tag Details pane on right side, you see that the name changed from the orange one to the yellow one. But this isn't reported correctly on the Tag Changes pane (left). On Tag Changes pane, it says yellow ➜ orange.

What is the expected behaviour ?

Reporting correct order for the name change the same way Tag Details table is reporting. (i.e. orange ➜ yellow)

When does this occur ?

For example when "A ➜ B" is made of RTL parts A and B.

How do we replicate the issue ?

  1. Visit https://osmcha.org/changesets/114891337
  2. Look at name change for way 388910106

Please tell us about your environment:

Firefox 95

Proposed solution:

Isolating A and B using <bdi> html tag to clear the situation for the bidirectional algorithm. (See Isolation at Unicode Bidirectional Algorithm basics)

@ahangarha
Copy link

Since the arrow is hard coded, my proposal is to apply flex display on the wrapper. It seems it fixes the issue without making any side effect.

image

I can work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants