Fix: incorrect activity path for NotificationOpenedActivityHMS

[jinliu9508]

Description

One Line Summary

Fix the class path of NotificationOpenedActivityHMS so it can be consistent with the path returned by the backend service.

Details

Motivation

NotificationOpenedActivityHMS is currently broken for all Huawei devices on V5 because the class path is currently under com.onesignal.notifications.activities instead of com.onesignal used in our backend service. This PR moves the class so the path is in consistent with that used by the backend service.

Scope

RECOMMEND - OPTIONAL - What is intended to be effected. What is known not to change. Example: Notifications are grouped when parameter X is set, not enabled by default.

Testing

Manual testing

1. Place a breakpoint inside processOpen().
2. Send a HMS notification and click it.
3. Observe that the breakpoint is never reached.
4. Apply the fix and repeat the steps above. Observe that the breakpoint has reached and the intent includes some custom data.

Affected code checklist

• Notifications
  • Display
  • Open
  • Push Processing
  • Confirm Deliveries
• Outcomes
• Sessions
• In-App Messaging
• REST API requests
• Public API changes

Checklist

Overview

• I have filled out all REQUIRED sections above
• PR does one thing
  • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
• Any Public API changes are explained in the PR details and conform to existing APIs

Testing

• I have included test coverage for these changes, or explained why they are not needed
• All automated tests pass, or I explained why that is not possible
• I have personally tested this on my device, or explained why that is not possible

Final pass

• Code is as readable as possible.
  • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
• I have reviewed this PR myself, ensuring it meets each checklist item
  • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

---

This change is 

[jkasten2]

Left 2 feedback items that we should put comments in the code.

Let's also add a test, the test should use Class.forName("...") so it will fail if someone ever tries to use a refactoring tool and doesn't read the comments either.

[jkasten2]

Let's add a comment here that we can't change the android:name, since the OneSignal backend incudes it in the payload.

[jinliu9508]

Good suggestion. I have added the comment for the change.

[jkasten2]

Let's also put a comment here and before the class definition too.

[jinliu9508]

Good suggestion. I have added the comment for the change. Note that I added it below the first line as first line comment is not allowed in the coding standard.

[jinliu9508]

Left 2 feedback items that we should put comments in the code.

Let's also add a test, the test should use Class.forName("...") so it will fail if someone ever tries to use a refactoring tool and doesn't read the comments either.

Good point. I have added comments and a new test unit that specifically tests for the class path.