Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate grouped-query attention into APT class #52

Open
pascalnotin opened this issue Sep 11, 2023 · 9 comments
Open

Integrate grouped-query attention into APT class #52

pascalnotin opened this issue Sep 11, 2023 · 9 comments
Assignees

Comments

@pascalnotin
Copy link
Collaborator

  1. We should have one parameter in the config that specifies the type of attention ('standard' vs 'grouped-query')
  2. We should extend the APTAttention class to include grouped-query attention
  3. The PR should include unit test to confirm grouped-query attention works as expected
@RishikeshMagar
Copy link
Contributor

RishikeshMagar commented Sep 14, 2023

Hi, I'm new here and would like to contribute to this project. Can I take a look at this issue? I'm still getting the hang of unit tests, so I might need some guidance in that area. Thanks!

@pascalnotin
Copy link
Collaborator Author

Hi @RishikeshMagar -- welcome to the project! Two other colleagues (Buttercutter and Leo Chen on discord) have expressed interest in this issue as well and have started coordinating on an approach. They will be reaching out to you re: next steps / how to collaborate on this issue :)

@Leo-T-Zang
Copy link
Contributor

/take

@Leo-T-Zang
Copy link
Contributor

Hi @RishikeshMagar, What is your discord username? We can discuss there.

@RishikeshMagar
Copy link
Contributor

Thanks @pascalnotin. I will connect with them.

Hi @Leo-T-Zang,
Sure, we can connect on discord. My discord user name is Rishi. Thanks!

@Leo-T-Zang
Copy link
Contributor

@RishikeshMagar, can you send a messege to me? user name is Leo Chen and handle is tz6352

@RishikeshMagar
Copy link
Contributor

Sure @Leo-T-Zang, I will send you a message on discord sometime today.

@pascalnotin pascalnotin moved this from Todo to In Progress in project-lm-scaling Sep 21, 2023
@RishikeshMagar
Copy link
Contributor

@pascalnotin
Just an FYI, I have implemented this and butter cutter from discord is helping me out with tests for this. I should be able to submit a PR this weekend

@pascalnotin
Copy link
Collaborator Author

Fantastic - thank you both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

3 participants