Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backend] fix capability check on feeds (#9573) #9574

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[backend] fix capability check on feeds (#9573) #9574

wants to merge 2 commits into from
+68 −15

Conversation

lndrtrbn
Copy link
Member

Proposed changes

  • Fix capability checks

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@lndrtrbn lndrtrbn added the filigran team use to identify PR from the Filigran team label Jan 13, 2025
@lndrtrbn lndrtrbn self-assigned this Jan 13, 2025
@lndrtrbn lndrtrbn linked an issue Jan 13, 2025 that may be closed by this pull request
Cannot access CSV and TAXII feed if user has only capability to manage feeds #9573
Open
@SouadHadjiat
Copy link
Member

just need to fix tests @lndrtrbn (adding capa to editor user changes the counters, since it adds an internal relationship between role & capa)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SouadHadjiat SouadHadjiat SouadHadjiat approved these changes

Assignees

@lndrtrbn lndrtrbn

Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot access CSV and TAXII feed if user has only capability to manage feeds
2 participants
@lndrtrbn @SouadHadjiat