Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sppl #5

Merged
merged 2 commits into from
May 6, 2024
Merged

feat: add sppl #5

merged 2 commits into from
May 6, 2024

Conversation

ships
Copy link
Contributor

@ships ships commented Apr 19, 2024

Adds SPPL as a python package that will now be consumed from this repo like so:

nix  build github:OpenGen/nix#sppl

This invocation will not work until this is merged -- for now, you must specify a sha:

nix  build github:OpenGen/nix/85a5938b099488d963fe256c0011491da8fb5da9#sppl

Once this is merged, we can update documentation and finish chi-collective/GenSQL.query#110 . Then once that is in, we can also open a PR to have an OCI image built here (or there, if we configure the whole OpenGen org with Docker Hub credentials, instaed of just this repo).

@ships ships force-pushed the ships/add-sppl branch 4 times, most recently from b27e394 to 459f934 Compare April 26, 2024 22:26
@ships ships changed the title feat: add sppl and oci image for same feat: add sppl May 2, 2024
@ships ships force-pushed the ships/add-sppl branch from 459f934 to 2b329e4 Compare May 2, 2024 19:30
@ships ships force-pushed the ships/add-sppl branch from 2b329e4 to 85a5938 Compare May 2, 2024 19:32
@ships ships marked this pull request as ready for review May 2, 2024 19:34
@ships ships requested a review from KingMob May 2, 2024 22:32
Copy link
Contributor

@KingMob KingMob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I can confirm it builds with the SHA.

@ships ships force-pushed the ships/add-sppl branch from f762bb7 to a29a170 Compare May 3, 2024 21:35
The GitHub (rather than PyPi) pinned source can be
removed once it is released as 2.0.5 or greater on Pypi.
@ships ships force-pushed the ships/add-sppl branch from a29a170 to 5dda8d9 Compare May 4, 2024 00:46
@ships ships merged commit 051fd3e into main May 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants