Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] dependency supports-ansi has issues related to triviality (and more) #58

Open
DerekNonGeneric opened this issue Jul 17, 2022 · 0 comments

Comments

@DerekNonGeneric
Copy link
Member

According to Socket, supports-ansi has several issues; the most notable of which is that it is considered a trivial package. It also does not support Cygwin, which is unacceptable. There do not appear to be any good alternatives, but the reason why we perform this check in the first place is to determine whether to use color, so we may be able to use supports-color in the near-term.

Depending on whether we swap out cli-color for colorette and colorette were to perform this check itself, we may be able to remove this dependency entirely. There are, however, additional uses for determining whether ANSI is supported other than coloring (e.g., bold, underline, italic), which is something to consider.

Additionally, we should detect whether we are running in a browser and convert ANSI-escaped text streams to HTML for document and devconsole output (as seen in ansi-to-html), but that should only be anticipated once isomorphic support is added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant