Issue436 - Automated test case versionless feature server.xml #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/test/GradleSingleModLCLSTest.ts
Outdated
| if (pointerBlockedElement) { | ||
| await driver.executeScript("arguments[0].style.display = 'none';", pointerBlockedElement); | ||
| } else { | ||
| console.log('pointerBlockElementt not found!'); |
There was a problem hiding this comment.
Please put valid log statements.
src/test/GradleSingleModLCLSTest.ts
Outdated
| focusTargtElemnt.click(); | ||
| await editor.click(); | ||
|
|
||
| const actns = VSBrowser.instance.driver.actions(); |
There was a problem hiding this comment.
Typo actions. Kindly check for similar typos.
src/test/GradleSingleModLCLSTest.ts
Outdated
| await actns.move({ origin: focusTargtElemnt }).perform(); | ||
| await utils.delay(5000); | ||
|
|
||
| const hverContent = editor.findElement(By.className('hover-contents')); |
There was a problem hiding this comment.
Kindly be aware while naming variables. It should be meaningful and should not have typos. It is considered as a good practice :)
src/test/GradleSingleModLCLSTest.ts
Outdated
| if (pointerBlockedElement) { | ||
| await driver.executeScript("arguments[0].style.display = 'none';", pointerBlockedElement); | ||
| } else { | ||
| console.log('pointerBlockElementt not found!'); |
There was a problem hiding this comment.
Please put meaningful log statements.
There was a problem hiding this comment.
Kindly check for similar log statements.
…com/SuparnaSuresh/liberty-tools-vscode into AutomatedTestCaseVersionlessFeature
| @@ -1,3 +1,4 @@ | |||
|
|
|||
| /** | |||
| * Copyright (c) 2020, 2022 IBM Corporation. | |||
There was a problem hiding this comment.
Update the year in copyright header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR raised for Fixes #436 includes
Fixes #442
Fixes #443
Fixes #444
Fixes #445
Fixes #446
Fixes #446
Fixes #447
Fixes #448
Automated the test cases for server.xml versionless features.