From f59705287597f78fbcdb8cd8d70b21da6813a224 Mon Sep 17 00:00:00 2001 From: navaneethsnair1 Date: Wed, 18 Sep 2024 17:12:05 +0530 Subject: [PATCH 1/4] address issues associated with guides in singlepane --- src/main/content/_assets/css/guide-common.scss | 16 ++++++++++++++++ .../content/_assets/css/guide-multipane.scss | 9 +++++++++ src/main/content/_assets/js/guide-common.js | 1 + 3 files changed, 26 insertions(+) diff --git a/src/main/content/_assets/css/guide-common.scss b/src/main/content/_assets/css/guide-common.scss index d1af84a2d8..f5ea267e97 100644 --- a/src/main/content/_assets/css/guide-common.scss +++ b/src/main/content/_assets/css/guide-common.scss @@ -512,6 +512,14 @@ #guide_content .code_command > .code_block_wrapper:before { display: none; } + + .view_code{ + display: block; + } + + .code_command pre{ + cursor:text; + } } @media (min-width: 1170px) { @@ -519,6 +527,14 @@ background-image: inherit; margin-bottom: 0; } + + .view_code{ + display: none; + } + + .code_command pre{ + cursor:pointer; + } } @media (min-width: 1440px) { diff --git a/src/main/content/_assets/css/guide-multipane.scss b/src/main/content/_assets/css/guide-multipane.scss index 75e53bda2b..230bfe2e6a 100644 --- a/src/main/content/_assets/css/guide-multipane.scss +++ b/src/main/content/_assets/css/guide-multipane.scss @@ -324,6 +324,15 @@ body { } } +@media (max-width: 1169.98px){ + .copyFileButton{ + right: 40px; + &:hover { + right: 39px; + } + } +} + .CodeRay .line-numbers { display: inline-block; visibility: hidden; diff --git a/src/main/content/_assets/js/guide-common.js b/src/main/content/_assets/js/guide-common.js index 594a3f37c3..6e24052733 100644 --- a/src/main/content/_assets/js/guide-common.js +++ b/src/main/content/_assets/js/guide-common.js @@ -488,6 +488,7 @@ $(document).ready(function () { }); $(window).on("resize", function () { + (inSingleColumnView()) ? $(".code_command").removeClass("hotspot") : $(".code_command").addClass("hotspot"); if (!inSingleColumnView()){ $("#code_column").css("top", "0px"); } From e3d1ef9567c727dc25fa028ad98e87d626d38886 Mon Sep 17 00:00:00 2001 From: JavierABarreto Date: Tue, 19 Nov 2024 09:54:39 -0600 Subject: [PATCH 2/4] rebasing prod --- src/main/content/_assets/css/guide-common.scss | 16 ---------------- .../content/_assets/css/guide-multipane.scss | 9 --------- src/main/content/_assets/js/guide-common.js | 1 - 3 files changed, 26 deletions(-) diff --git a/src/main/content/_assets/css/guide-common.scss b/src/main/content/_assets/css/guide-common.scss index f5ea267e97..d1af84a2d8 100644 --- a/src/main/content/_assets/css/guide-common.scss +++ b/src/main/content/_assets/css/guide-common.scss @@ -512,14 +512,6 @@ #guide_content .code_command > .code_block_wrapper:before { display: none; } - - .view_code{ - display: block; - } - - .code_command pre{ - cursor:text; - } } @media (min-width: 1170px) { @@ -527,14 +519,6 @@ background-image: inherit; margin-bottom: 0; } - - .view_code{ - display: none; - } - - .code_command pre{ - cursor:pointer; - } } @media (min-width: 1440px) { diff --git a/src/main/content/_assets/css/guide-multipane.scss b/src/main/content/_assets/css/guide-multipane.scss index 230bfe2e6a..75e53bda2b 100644 --- a/src/main/content/_assets/css/guide-multipane.scss +++ b/src/main/content/_assets/css/guide-multipane.scss @@ -324,15 +324,6 @@ body { } } -@media (max-width: 1169.98px){ - .copyFileButton{ - right: 40px; - &:hover { - right: 39px; - } - } -} - .CodeRay .line-numbers { display: inline-block; visibility: hidden; diff --git a/src/main/content/_assets/js/guide-common.js b/src/main/content/_assets/js/guide-common.js index 6e24052733..594a3f37c3 100644 --- a/src/main/content/_assets/js/guide-common.js +++ b/src/main/content/_assets/js/guide-common.js @@ -488,7 +488,6 @@ $(document).ready(function () { }); $(window).on("resize", function () { - (inSingleColumnView()) ? $(".code_command").removeClass("hotspot") : $(".code_command").addClass("hotspot"); if (!inSingleColumnView()){ $("#code_column").css("top", "0px"); } From f8998a21726c4ab6f46905c161a3d757fae4e3d2 Mon Sep 17 00:00:00 2001 From: navaneethsnair1 Date: Fri, 3 Jan 2025 15:54:17 +0530 Subject: [PATCH 3/4] changing aria-label of footer_get_started_link --- src/main/content/_includes/footer.html | 2 +- src/main/content/antora_ui/src/partials/footer-content.hbs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/content/_includes/footer.html b/src/main/content/_includes/footer.html index 8c8e9d0c38..f6fd6493b3 100644 --- a/src/main/content/_includes/footer.html +++ b/src/main/content/_includes/footer.html @@ -31,7 +31,7 @@ {% t footer.logos %}