Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC00158]: revamp webfonts + font-families attribution #402

Open
33 of 34 tasks
Lungsangg opened this issue Oct 16, 2024 · 5 comments
Open
33 of 34 tasks

[RFC00158]: revamp webfonts + font-families attribution #402

Lungsangg opened this issue Oct 16, 2024 · 5 comments
Assignees

Comments

@Lungsangg
Copy link
Collaborator

Lungsangg commented Oct 16, 2024

current situation

the serif/ sans-serif attribution in Sefaria doesn't correspond to our needs for Tibetan. So there is nothing much but hacks that can be done in the current situation.

Solution

each language should be treated independently from the others so that no interference happens.
we should have the ability to set the size/font/color/etc. for each part of the website for each locale.

Implementation steps

Step 1 (Lungsang)

  • Reset the font groupings to its initial Sefaria state

Step 2 (Lungsang)

  • check in the card with the required sizes and fonts what needs to be modified
  • write documentations in wiki about existing grouping system wiki link
  • when applying different color and size for tibetan and english, there shouldnt be any changes on the other language.
    • Search a solution
    • write documentation wiki link
    • Implement the solution in code
      • Text page
      • Topics page
      • Community page
      • Profile page
      • Collection page
      • Account setting page
      • Registration page
      • Resources

These are the changes to check

Texts main page

  • main header: sans-serif 18px black

Image

  • search: serif 16pt

Image

  • description: sans-serif 17pt

Image

  • ཡིག་མཛོད་ཀྱི་དཀར་ཆ་ལ་ལྟ།: 17pt

Image

  • categories: 24pt

Image

  • category description: serif 16px

Image

Text

  • category of text: 17px

Image

  • versions: 20px

Image

  • version title: serif 20px

Image

  • version history: sans-serif 15px

Image

  • ཕབ་ལེན།: 20px

Image

Reader App

  • resources: sans-serif 18px

Image

  • menu items: serif 18px

Image

  • menu categories: sans-serif 16px

Image

  • search message: 18px

Image

  • buttons: serif 18px

Image

  • ལུང་འགོད་སའི་ཟིན་བྲིས་འདེམས།: 18px

Image

Topics

  • topics search: 16px

Image

  • ཀ་ཁ་: 26px

Image

  • New Sheet buttons: serif 16px

Image

Community

  • Join the conversation: serif 28px ---- seems like this is disabled

Image

Bookmarks

  • History: sans-serif 18px

Image

  • date: sans-serif 14px

Image

Profile menu

  • menu items: serif 17px

Image

  • logout: serif 17px

Image

Profile

  • buttons: 18px

Image

  • Sheets-collections-comments menu: 20px

Image

@Lungsangg Lungsangg self-assigned this Oct 16, 2024
@Lungsangg Lungsangg converted this from a draft issue Oct 16, 2024
@Lungsangg Lungsangg changed the title RFC00159: revamp webfonts + font-families attribution RFC00158: revamp webfonts + font-families attribution Oct 18, 2024
@Lungsangg Lungsangg changed the title RFC00158: revamp webfonts + font-families attribution [RFC00158]: revamp webfonts + font-families attribution Oct 18, 2024
@Lungsangg Lungsangg moved this from IN PROGRESS to TO DO in Pecha.org Web Dev Nov 14, 2024
@kaldan007 kaldan007 moved this from TO DO to IN PROGRESS in Pecha.org Web Dev Nov 28, 2024
@drupchen drupchen moved this from IN PROGRESS to BLOCKED in Pecha.org Web Dev Dec 3, 2024
@drupchen drupchen moved this from BLOCKED to TO DO in Pecha.org Web Dev Dec 9, 2024
@Lungsangg Lungsangg moved this from TO DO to IN PROGRESS in Pecha.org Web Dev Dec 11, 2024
@Lungsangg Lungsangg moved this from IN PROGRESS to TO DO in Pecha.org Web Dev Dec 16, 2024
@lobsam lobsam moved this from TO DO to IN PROGRESS in Pecha.org Web Dev Dec 17, 2024
@ta4tsering ta4tsering moved this from IN PROGRESS to TESTING in Pecha.org Web Dev Dec 25, 2024
@ta4tsering ta4tsering assigned drupchen and unassigned Lungsangg Dec 25, 2024
@drupchen
Copy link

drupchen commented Jan 2, 2025

Font sizes don't correspond

@kaldan007 kaldan007 moved this from TESTING to IN PROGRESS in Pecha.org Web Dev Jan 3, 2025
@kaldan007 kaldan007 assigned Lungsangg and unassigned drupchen Jan 3, 2025
@drupchen
Copy link

drupchen commented Jan 7, 2025

@Lungsangg webfont not applied

  • 1.

Image

  • 2.

Image

  • 3. ཧེ་བྲུ། is not webfont

Image

  • 4. བཟོ་བཅོས་ཀྱི་ལོ་རྒྱུས། and ཨིན་ཇི། and སྒྲིག་བཞིན་ཡོད།

Image

Image

Image

Image

  • 8. not applied

Image

  • 9. not applied in search results

Image

  • 10. new sheet

Image

@Lungsangg Lungsangg moved this from IN PROGRESS to TO DO in Pecha.org Web Dev Jan 8, 2025
@kaldan007 kaldan007 moved this from TO DO to IN PROGRESS in Pecha.org Web Dev Jan 15, 2025
@Lungsangg Lungsangg moved this from IN PROGRESS to TESTING in Pecha.org Web Dev Jan 16, 2025
@Lungsangg
Copy link
Collaborator Author

Lungsangg commented Jan 16, 2025

@drupchen la, looks like we have disabled "join the conversation" title in community page, so i didn't applied the text size.

@kaldan007 kaldan007 assigned drupchen and unassigned Lungsangg Jan 17, 2025
@kaldan007 kaldan007 moved this from TESTING to IN PROGRESS in Pecha.org Web Dev Jan 21, 2025
@Lungsangg
Copy link
Collaborator Author

Lungsangg commented Jan 24, 2025

Image

  • Image

  • input string when write text on མཆན། གཞན་གྱིས་མཐོང་མི་ཐུབ། place holder
    Image

@kaldan007 kaldan007 moved this from IN PROGRESS to TESTING in Pecha.org Web Dev Jan 24, 2025
@kaldan007 kaldan007 assigned drupchen and unassigned Lungsangg Jan 24, 2025
@Lungsangg
Copy link
Collaborator Author

@drupchen la, Right now i couldn't find any solution to load webfont on form placeholder. So login and register form placer holder doesn't have webfont right now. I will continue to look into it and push the changes once i found a solution for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: TESTING
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants