Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed and cadence sensors display values >0 when idle detection detected a stop #1995

Open
lsuhrbier opened this issue Oct 10, 2024 · 4 comments · Fixed by #2029
Open

Speed and cadence sensors display values >0 when idle detection detected a stop #1995

lsuhrbier opened this issue Oct 10, 2024 · 4 comments · Fixed by #2029
Assignees
Labels
enhancement New feature or request

Comments

@lsuhrbier
Copy link

After having stopped the idle detection, non-zero values are displayed from speed and cadence sensors. It appears, the last measured values are shown and not reset to zero or not read again from the sensor after idle detection detected a stop.

@lsuhrbier lsuhrbier added the potential bug A bug that could not (yet) be reproduced label Oct 10, 2024
@dennisguse dennisguse added enhancement New feature or request and removed potential bug A bug that could not (yet) be reproduced labels Oct 14, 2024
@dennisguse
Copy link
Member

Code looks like this is a valid complaint.
Relevant code:

  • TrackPointCreator.reset() [called by idle]
  • SensorDataSet.reset()

Later on used by:

  • TrackRecordingManager.getDataForUI()

Culprit may be children of Aggregator and the implementation of Aggregator.reset().
If I understood the code (I wrote), only accumulated values (like distance) are reset, but not the actual measurements (like speed, cadence, power).
So, the problem seems to be happening during the idle situation.

@dennisguse
Copy link
Member

PS/ you may be idle while a cadence sensor reports values - HR will do this as well :D

@dennisguse
Copy link
Member

Likely related: #1925

@dennisguse
Copy link
Member

The fix is broken... See #2043.

@dennisguse dennisguse reopened this Jan 20, 2025
@dennisguse dennisguse self-assigned this Feb 16, 2025
dennisguse added a commit that referenced this issue Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants