Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Add Missing Erc1155 E2E Tests #482

Open
1 of 7 tasks
0xNeshi opened this issue Jan 10, 2025 · 1 comment · May be fixed by #488
Open
1 of 7 tasks

[Feature]: Add Missing Erc1155 E2E Tests #482

0xNeshi opened this issue Jan 10, 2025 · 1 comment · May be fixed by #488
Labels
effort: low Easy or tiny task that takes less than a day. good first issue Good for newcomers. priority: 1 We will do our best to deal with this. type: test Changes to the testing suite.
Milestone
Release v0.2.0

Comments

@0xNeshi
Copy link
Collaborator

0xNeshi commented Jan 10, 2025 •
edited
Loading

What is the feature you would like to see?

  • Add missing receiver-related tests for _burn and _burn_batch:

    • errors_when_receiver_reverts_with_reason
    • errors_when_receiver_reverts_without_reason
    • errors_when_receiver_panics
    • errors_when_invalid_receiver_contract

  • Double-check for any other missing tests

https://github.com/OpenZeppelin/rust-contracts-stylus/blob/main/examples/erc1155/tests/erc1155.rs

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
@0xNeshi 0xNeshi added priority: 1 We will do our best to deal with this. type: test Changes to the testing suite. good first issue Good for newcomers. effort: low Easy or tiny task that takes less than a day. labels Jan 10, 2025
@bidzyyys bidzyyys added this to the Release v0.2.0 milestone Jan 10, 2025
@MukulKolpe
Copy link
Contributor

Hey @0xNeshi, @bidzyyys. Can I work on this issue?

@Dhanraj30 Dhanraj30 linked a pull request Jan 11, 2025 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: low Easy or tiny task that takes less than a day. good first issue Good for newcomers. priority: 1 We will do our best to deal with this. type: test Changes to the testing suite.
Projects
Rust Contracts Stylus
Status: Todo
Milestone
Release v0.2.0
Development

Successfully merging a pull request may close this issue.

Feat: Add missing tests for Erc1155 E2E Tests Dhanraj30/rust-contracts-stylus
3 participants
@0xNeshi @bidzyyys @MukulKolpe