Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Add Missing Erc721 E2E Tests #483

Open
1 of 3 tasks
0xNeshi opened this issue Jan 10, 2025 · 2 comments · May be fixed by #489
Open
1 of 3 tasks

[Feature]: Add Missing Erc721 E2E Tests #483

0xNeshi opened this issue Jan 10, 2025 · 2 comments · May be fixed by #489
Assignees
@DarkLord017
Labels
effort: low Easy or tiny task that takes less than a day. good first issue Good for newcomers. priority: 1 We will do our best to deal with this. type: test Changes to the testing suite.
Milestone
Release v0.2.0

Comments

@0xNeshi
Copy link
Collaborator

0xNeshi commented Jan 10, 2025

What is the feature you would like to see?

  • Add missing receiver-related tests for _safe_mint:
  • Double-check for any other missing tests

https://github.com/OpenZeppelin/rust-contracts-stylus/blob/main/examples/erc721/tests/erc721.rs

For inspiration, use Erc1155 tests

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
@0xNeshi 0xNeshi added priority: 1 We will do our best to deal with this. type: test Changes to the testing suite. good first issue Good for newcomers. effort: low Easy or tiny task that takes less than a day. labels Jan 10, 2025
@DarkLord017
Copy link

Hey @0xNeshi can i work on this issue ?

@bidzyyys
Copy link
Collaborator

Sure @DarkLord017!

@bidzyyys bidzyyys added this to the Release v0.2.0 milestone Jan 10, 2025
This was referenced Jan 11, 2025
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DarkLord017 DarkLord017

Labels
effort: low Easy or tiny task that takes less than a day. good first issue Good for newcomers. priority: 1 We will do our best to deal with this. type: test Changes to the testing suite.
Projects
Rust Contracts Stylus
Status: Todo
Milestone
Release v0.2.0
3 participants
@0xNeshi @bidzyyys @DarkLord017