Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hospitality: Blacklist for item gifting #821

Closed
chief-turkler opened this issue Sep 8, 2024 · 1 comment
Closed

Hospitality: Blacklist for item gifting #821

chief-turkler opened this issue Sep 8, 2024 · 1 comment
Labels
enhancement This would improve the mod in question.

Comments

@chief-turkler
Copy link

What problem does your suggestion solve
There are a lot of items, like ammo from Combat Extended, which add items which really shouldn't appear as gifts. I've gotten reports of this being an issue from users of my mods:

image

Describe the solution you propose
An XML tag to blacklist items from gift generation would solve this issue.

Describe alternatives you've considered
Hard-coding the blacklisted defs in the assemblies would work too, wouldn't even be that hard.

        string defName = thing.def.defName;
        if (defName.StartsWith("Ammo_") || defName.StartsWith("AVCE_Ammo_"))

This would, however, just kick the bucket down the road. This would start to be a bother as more and more mods ask for their items to be blacklisted as well. An XML tag you can slap onto any def would be far more modular.

Adding features takes a lot of time. Please consider becoming a patron to support development.

@chief-turkler chief-turkler added the enhancement This would improve the mod in question. label Sep 8, 2024
@OrionFive
Copy link
Owner

Hospitality just uses the built-in RimWorld gift system.

So without Hospitality this can happen just the same. So this is a general issue, not a Hospitality one. I suppose it should be reported to Ludeon instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This would improve the mod in question.
Projects
None yet
Development

No branches or pull requests

2 participants