Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve method mappings, particularly for specialized methods #2

Open
SpaceWalkerRS opened this issue Jul 22, 2024 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@SpaceWalkerRS
Copy link
Member

  1. Some methods inherited from libraries or the JDK, and while the synthetic bridge methods are not obfuscated, the specialized methods are. Rather than giving these methods intermediary names, these methods should inherit the name from their bridge counterpart.

  2. The same should happen for MC's own methods. This makes method inheritance clearer as all methods in the entire inheritance chain will have the same name. This will require an update the Mapping Utils' Propagator though, as it assumes intermediary names are entirely unique within a class.

@SpaceWalkerRS SpaceWalkerRS added the enhancement New feature or request label Jul 22, 2024
@zeichenreihe
Copy link

100% agree, the specialized/bridge methods need better handeling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants