New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

predict_fit_and_ci is unnecessarily verbose #76

Open

R-Walmsley opened this issue Oct 21, 2022 · 0 comments

Member

R-Walmsley commented Oct 21, 2022

Should be possible to replace:

x <-  data.matrix(new_data[, transf_labels] - rep(cm_transf_df[, transf_labels], by = nrow(new_data)))
t_x <- data.matrix(as.matrix(t(x)))

With:

x <-  data.matrix(new_data[, transf_labels] - cm_transf_df[, transf_labels]) # The "by" wasn't actually doing anything, but the operation is vectorised
t_x <- t(x)

The text was updated successfully, but these errors were encountered:

R-Walmsley mentioned this issue

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment