Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feeding Upgrade does not increase thirst value with newest ToughAsNails 1.20.1 #1204

Open
DuraBrite opened this issue Nov 15, 2024 · 1 comment
Labels
question Further information is requested

Comments

@DuraBrite
Copy link

Describe the bug
When using the "Feeding Upgrade" in Sophisticated Backpacks with Tough As Nails version 9.2.0.171, the thirst bar of the player does not change, when eating food with a designated thirst value. Before upgrading from Tough As Nails 9.0.0.96 to 9.2.0.171, the Feeding Upgrade still restored hunger and thirst.

To Reproduce

  1. Ensure Tough As Nails (9.2.0.171), Sophisticated Backpacks (3.20.12.1126), and Sophisticated Core (0.7.2.756) are installed.
  2. Create a data pack that assigns a thirst value to a food item, e.g., melon slices, with this JSON at toughasnails/tags/items/thirst/2_thirst_drinks.json
{
  "replace": true,
  "values": [
    "minecraft:melon_slice"
  ]
}
  1. Add the Feeding Upgrade to a backpack and place melon slices in it.
  2. Allow the Feeding Upgrade to automatically consume the melon slice as hunger decreases.
  3. Observe that the thirst value is not restored.

Expected behavior
If an item has a thirst value, it should also increase the player's thirst level when consumed by the Feeding Upgrade. (Just like it worked with Tough As Nails version 9.0.0.96.

Versions

  • Minecraft: 1.20.1 with Forge 47.3.11
  • Tough As Nails: 9.2.0.171
  • Sophisticated Core: 0.7.2.756
  • Sophisticated Backpacks: 3.20.12.1126
@P3pp3rF1y
Copy link
Owner

You should really report this to them if it stopped working because of their update. I don't have any special compatibility on my side for the mod and I don't intend to add one and as far as I can see I am setting the food in player's hand properly and firing the correct method / event and this is a thing that works with other mods that rely on player eating (like Spice of Life). I will leave this open for a bit and feel free to come back with more info from them if they have any, but Tough as Nails should be the ones looking at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants