Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XP Tank Mending Feature to work with items in Curios slots as well #411

Open
midveid opened this issue Jan 31, 2022 · 2 comments
Open

XP Tank Mending Feature to work with items in Curios slots as well #411

midveid opened this issue Jan 31, 2022 · 2 comments
Labels
compatibility enhancement New feature or request

Comments

@midveid
Copy link

midveid commented Jan 31, 2022

As described in the title; the XP Tank mending feature is not functioning properly with things equipped in Curios API slots. For reference, these same accessories in Curios API slots repair fine when I pick up an XP orb but not with the backpack mending function.

Steps to reproduce the behaviour:

  1. Equip accessory that has durability and a mending enchant on it in a Curios API slot
  2. Enable mending feature in XP Pump tab of backpack
  3. Nothing happens to accessories enchanted with mending equipped in Curios API

Expected behaviour
Accessories are repaired by backpack.

Versions
1.16.5 - 3.15.1.503

@P3pp3rF1y
Copy link
Owner

Well, this is more a feature request as it works the same way that vanilla mending does. I am guess curios may be adding support for mending in its slots and that's why you would see it working there. The enhancement definitely makes sense to me and I will add it in the future.

@P3pp3rF1y P3pp3rF1y changed the title XP Tank Mending Feature not functioning properly with things equipped in Curios API XP Tank Mending Feature to work with items in Curios slots as well Jan 31, 2022
@P3pp3rF1y P3pp3rF1y added enhancement New feature or request compatibility labels Jan 31, 2022
@Jkosio23
Copy link

Shadows-of-Fire/Apotheosis#786 accidentally went to say something about this in apotheosis's github before realizing it was the wrong mod, but maybe this could help you implement it in SophBackpacks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants