-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the use of JointFitter (in astropy)? #190
Comments
This makes the JointFitter kind of problematic for PAHFIT at the moment:
But it's so much simpler to conceptualize than "figure out a way to blend your spectral segments". |
I am pretty sure the JointFitter can be enhanced to support fixed, bounded, and tied parameters. It has not been as fully developed as other fitters. |
Yeah honestly it seems to me that it's none of the optimizer's business that we're re-using the same parameter in a few different parts of the model/segments of the data. So it was surprising to me that there are any such constraints. A dead-simple version of a joint fitter would be just concatenate all the |
And this is what the JointFitter does for us. It just needs to get a little work to bring it up to the same standard as the LevMar fitter that is already there. I'm pretty sure there are even existing helper routines that can be used to do most of this work. This is even something I could try to do if it is a real priority for PAHFIT. And if we upgrade JointFitter, then everyone can get the benefit. |
Closing in favor of #291. |
input multiple spec with each their pack, information which parameters need to be the same in all spec. [https://docs.astropy.org/en/latest/modeling/jointfitter.html]
JD: "if using the joint fitter, we’ll be making more than one model for simul-fitting. I think this means we should create and keep a separate parameter table for all the input channels/segments/orders/whatever we call them." <-- Related to PR#165
Use AKARI + Spitzer as a test run ….
The text was updated successfully, but these errors were encountered: