-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce sigma_v + v_off, and remove line FWHM as a user-settable parameter #293
Comments
Couple of issues: in some systems it might be necessary to allow a "forked" line with both a One issue this brings up: |
Thinking again, maybe Note that the Sara Profile remapping (#288) would happen generically at the It's much easier to reason if we assume features are ~fixed in instrument resolution even as they are varied. |
Re-reading the above, it seems clear a core + broad component should just be introduced as two independent (or tied) features. |
A real ambiguity regarding the
Model
->Features
interface is what type of data is returned back into theFeatures
table. The most principled approach is to return only details of the scientific model. The FWHM of a line is not such a detail.Rather than letting users set that for unresolved lines, and having
Model
populate it after fit, it would be a cleaner approach if lines (and dust features) allowed an optionalsigma_v
(inkm/s
).sigma_v
(default units:km/s
) represents additional line width above and beyond that of the (Gaussian) instrumental line profile.There are some details about applying
sigma_v
, but it's by far then the cleanest approach: allFeatures
tables remain "unsullied" by artifacts of the instrumentation, and can hence be applied to any spectrum(/a) you throw at it (as long as they have valid instrument information)Then
fit
,tabulate
,plot
, etc. would not need a way to "override the instrument". They are always applying instrument details of the plotted/tabulated/fitted spectrum(/a).The text was updated successfully, but these errors were encountered: