You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Model.tabulate is slow, and relies on Model-recreation and a single hard-coded Fitter class. This is also part of why Model.plot is so slow.
How about the following idea for component computation:
Elevate Fitter to be a proper super-class.
Give Fitter it its own component methods, one for each component (starlight, blackbody, modified_blackbody, power_gaussian, power_drude). They will take wavelength and standardized component parameters in a fixed order
Make Model.tabulate use its own Fitter object compute (creating one if it needs to).
Model.tabulate can use rich keywords to return a dictionary of data, similar to the IDL pahfit_components, which had:
- We introduce tests to ensure all `Fitter`'s (including the parent class itself) give the same component outfit for the same input.
I think to start the base `Fitter` components would just be lifted from `APFitter`.
One minor variation of this is to create _two_ abstractions: `Fitter` and `Components`, with the latter doing the component work. But I think that's likely overkill.
The text was updated successfully, but these errors were encountered:
Model.tabulate
is slow, and relies onModel
-recreation and a single hard-codedFitter
class. This is also part of whyModel.plot
is so slow.How about the following idea for component computation:
Fitter
to be a proper super-class.Fitter
it its own component methods, one for each component (starlight
,blackbody
,modified_blackbody
,power_gaussian
,power_drude
). They will take wavelength and standardized component parameters in a fixed orderModel.tabulate
use its ownFitter
object compute (creating one if it needs to).Model.tabulate
can use rich keywords to return a dictionary of data, similar to the IDLpahfit_components
, which had:The text was updated successfully, but these errors were encountered: