Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage state information more cleanly #133

Open
dilpath opened this issue Jan 4, 2025 · 0 comments
Open

Manage state information more cleanly #133

dilpath opened this issue Jan 4, 2025 · 0 comments

Comments

@dilpath
Copy link
Member

dilpath commented Jan 4, 2025

Currently, the method state information is mostly stored in the candidate space object. All state information could be moved into a separate state object, such that the candidate space is no longer stateful. e.g. there are a few objects (Problem, ModelSubspace, ModelSpace, CandidateSpace) that each contain some logic to manage exclusions -- this could all be moved to the state object.

State information (some of which is only used by the FAMoS method currently):

  • each iteration:
    • the identified models
    • the calibrated models
    • the method
  • exclusions (accumulative over iterations)

Partially resolved by #128 , where all calibrated models from all iterations are now stored in Problem.state.

Use this in plotting code too, e.g.:

  • add method information from each iteration to graph_iteration_layers, to make FAMoS method switches clear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant