Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New-AcmePSKey invalid ValidateSet for RSAKeySize #125

Open
agowa opened this issue Dec 2, 2021 · 1 comment
Open

New-AcmePSKey invalid ValidateSet for RSAKeySize #125

agowa opened this issue Dec 2, 2021 · 1 comment

Comments

@agowa
Copy link

agowa commented Dec 2, 2021

I updated the module and my script now fails. The ValidateSet for RSAKeySize does not allow "4096" as RSAKeySize, even though the code afterwards checks for it. Therefore I assume that the ValidateSet is wrong.

ACME-PS/dist/ACME-PS/ACME-PS.psm1

Line 1298 in 82ffcb2

[ValidateSet(2048)]

@glatzert
Copy link
Collaborator

glatzert commented Dec 2, 2021

Most likely.
If you care to make a PR, I'll publish an update 'right away'.
If not, I'll take care this weekend :)

agowa pushed a commit to agowa/ACME-PS that referenced this issue Dec 2, 2021
Update RSAKeySize ValidateSet
594623c 
Update RSAKeySize ValidateSet to include 4096
Fixes PKISharp#125
@agowa agowa mentioned this issue Dec 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update RSAKeySize ValidateSet agowa/ACME-PS
2 participants
@agowa @glatzert