Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Logging - Stdout formatting is stripped by the logging process #335

Open
JohnJacobsonIII opened this issue May 21, 2021 · 0 comments
Assignees
Labels
bug good first issue A good place to start make Involves touching GNU Makefiles

Comments

@JohnJacobsonIII
Copy link
Collaborator

Bug Report

Description:
This issue is connected to Issue #331.
Output to stdout from makefiles is currently formatted (with colored text) for improved readability. The current process for logging makefile events (#331) strips all formatting as it tee's all output to logfiles.

Suggested Fix:

  1. There are some commands to force retention of color (grep --color=always, passing through script, probably many others I haven't explored) but most of these will write extra text to the logs as well. These could be used in conjunction with careful purification of the logs.
  2. Change the makefile logging control flow. The current flow enables --output-sync for safe parallel log writing, but there are likely other ways to implement this in make calls without adjusting basic output.
@JohnJacobsonIII JohnJacobsonIII self-assigned this May 21, 2021
@JohnJacobsonIII JohnJacobsonIII added bug good first issue A good place to start make Involves touching GNU Makefiles labels May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue A good place to start make Involves touching GNU Makefiles
Projects
None yet
Development

No branches or pull requests

1 participant