Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit - Medium 03 #8

Open
Kogaroshi opened this issue Mar 31, 2023 · 0 comments
Open

Audit - Medium 03 #8

Kogaroshi opened this issue Mar 31, 2023 · 0 comments

Comments

@Kogaroshi
Copy link
Contributor

Incorrect fee scaling
In the Dullahan Fee Module, in case the utilization rate goes over the threshold, a multiplier is applied to the base fee to increase it.
But the current multiplier is scaled with an extra 1e18 which brings the calculated currentFee to be way too big compared to wanted values.

Fix : #7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Kogaroshi