Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: Update and delete buttons of event modal are not working #1013

Closed
kanhaiya04 opened this issue Oct 29, 2023 · 5 comments · Fixed by #1051
Closed

Bug Report: Update and delete buttons of event modal are not working #1013

kanhaiya04 opened this issue Oct 29, 2023 · 5 comments · Fixed by #1051
Assignees
Labels
bug Something isn't working feature request

Comments

@kanhaiya04
Copy link
Contributor

Describe the bug
Update and delete buttons of the event modal are not working as expected.

To Reproduce
Steps to reproduce the behavior:

  1. Open events page.
  2. Open event modal of any event.
  3. Notice the update and delete icon in the bottom right are not working.

Expected behavior
The update and delete buttons should perform their respective tasks.

Actual behavior
Both the buttons are doing nothing.

Screenshots
Untitled design (2)

Additional details
Add any other context or screenshots about the feature request here.

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship PalisadoesFoundation/talawa#359

@kanhaiya04 kanhaiya04 added the bug Something isn't working label Oct 29, 2023
@kanhaiya04
Copy link
Contributor Author

@palisadoes Please assign me this issue.

@palisadoes
Copy link
Contributor

@rishav-jha-mech Is this addressed in your latest PR?

@rishav-jha-mech
Copy link
Contributor

@palisadoes Event and People screens were out of scope for my project. This modal should be redesigned according to the latest design standards. I'll update the figma file soon, for now @kanhaiya04 can work on this.

@kanhaiya04
Copy link
Contributor Author

Hey @rishav-jha-mech, I attempted to resolve this issue by updating the data-toggle and data-target attributes to data-bs-toggle and data-bs-target, respectively, following the guidelines from Bootstrap 5.3 documentation.

Now, the buttons are producing an error response, whereas previously, there was no response at all.

ERROR ne.getInstance(...) is null ./node_modules/bootstrap/dist/js/bootstrap.min.js/</<@http://localhost:3000/static/js/bundle.js:147739:13 i@http://localhost:3000/static/js/bundle.js:146670:53

Can you suggest me the fix?

@rishav-jha-mech
Copy link
Contributor

@kanhaiya04 follow react-bootstrap, using attribute based elements wont work here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants