Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade @pdfme/generator from 4.5.2 to 5.0.0 #2317

Closed
palisadoes opened this issue Oct 5, 2024 · 8 comments · Fixed by #2413
Closed

Upgrade @pdfme/generator from 4.5.2 to 5.0.0 #2317

palisadoes opened this issue Oct 5, 2024 · 8 comments · Fixed by #2413
Assignees
Labels
bug Something isn't working

Comments

@palisadoes
Copy link
Contributor

Rationale

  1. This was previously attempted by the automated dependabot job but the PR tests failed.
  2. This issue has been created to fix the issue as there may be multiple dependency requirements that need updating

This is a major revision upgrade and many files may need to be updated to the new syntax, functions, methods and classes

Task

  1. Upgrade the package
  2. Remove this package if it is:
    1. unused
    2. unnecessary. For example:
      1. the functionality can be maintained by using another package we are already using,
      2. If we are using only one function or class in the package you can consider replacing it with code that resides in this repository
      3. It is used by a feature that the end user is unlikely to ever use

Background Failing PRs and Tests

@palisadoes palisadoes added the bug Something isn't working label Oct 5, 2024
@Sumitsh28
Copy link

Can I work on this issue?

@Aryan4884
Copy link
Contributor

@palisadoes if no one working,please assign this to me.

@pranshugupta54
Copy link
Member

Hey @Sumitsh28, are you still working on this?

@Sumitsh28
Copy link

I was tied up with some other tasks. I'll create a PR soon.

@Sumitsh28
Copy link

I'm getting some errors while committing my code. Please help!

@palisadoes
Copy link
Contributor Author

Please ask the #talawa-admin slack channel. Provide screen shots

Copy link

github-actions bot commented Nov 7, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Nov 7, 2024
@Kunalpal216
Copy link
Contributor

If there are no updates by @Sumitsh28 , Can this issue be assigned to me @palisadoes ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants