Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write Unittests for src/screens/Users/Users.tsx #2376

Closed
palisadoes opened this issue Oct 27, 2024 · 11 comments
Closed

Write Unittests for src/screens/Users/Users.tsx #2376

palisadoes opened this issue Oct 27, 2024 · 11 comments
Assignees
Labels
good first issue Good for newcomers test Testing application

Comments

@palisadoes
Copy link
Contributor

We will need unittests done for all methods, classes and functions found in this file.

PR Acceptance Criteria

  1. When complete this file must show 100% coverage when merged into the code base.
  2. The current code coverage for the file can be found here
  3. CodeRabbit must approve all your changes to the test file(s) and the file(s) under test
  4. The PR will show a report for the code coverage for the file you have added. You can use that as a guide
  5. No functionality must be removed to achieve this goal
  6. All tests must be valid and truly test the code base

Other Criteria

  1. If this file isn't referenced in the code base then remove it. We don't want tests run on unused code

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@syedali237
Copy link
Contributor

Can I be assigned this issue?

@palisadoes
Copy link
Contributor Author

Can I be assigned this issue?

Our policy is to assign no more than two issues to each contributor across all repositories. This way everyone gets a chance to participate in the projects. We sometimes give exceptions for more urgent cases and sometimes we lose track, but the policy stands. You have reached your limit, please wait until your existing issues are closed before requesting more issues. You could unassign yourself from one of the other issues too.

@AnshulKahar2729
Copy link
Contributor

Assign me this, I can work on this.

@Kunalpal216
Copy link
Contributor

If there are no updates by @AnshulKahar2729 , Can this issue be assigned to me ?

@AnshulKahar2729
Copy link
Contributor

If there are no updates by @AnshulKahar2729 , Can this issue be assigned to me ?

It's my exam time, I will make the pr soon.

@palisadoes
Copy link
Contributor Author

During the week of November 11, 2024 we will start a code freeze on the develop branches in Talawa, Talawa Admin and Talawa-API.

We have completed a project to convert the Talawa-API backend to use PostgreSQL. Work will then begin with us merging code in the develop branches to a new develop-postrgres branch in each repository.

Planning activities for this will be managed in our #talawa-projects slack channel. A GitHub project will be created to track specially labeled issues. We completed a similar exercise last year using a similar methodology.

Starting November 12, California time no new PRs will be accepted against the develop branch. They must be applied to the develop-postrgres branch.

There are some GSoC project features that will need to be merged into develop. These will be the only exceptions.

This activity and the post GSoC 2024 start date was announced in our #general Slack channel last month as a pinned post.

@AnshulKahar2729
Copy link
Contributor

During the week of November 11, 2024 we will start a code freeze on the develop branches in Talawa, Talawa Admin and Talawa-API.

We have completed a project to convert the Talawa-API backend to use PostgreSQL. Work will then begin with us merging code in the develop branches to a new develop-postrgres branch in each repository.

Planning activities for this will be managed in our #talawa-projects slack channel. A GitHub project will be created to track specially labeled issues. We completed a similar exercise last year using a similar methodology.

Starting November 12, California time no new PRs will be accepted against the develop branch. They must be applied to the develop-postrgres branch.

There are some GSoC project features that will need to be merged into develop. These will be the only exceptions.

This activity and the post GSoC 2024 start date was announced in our #general Slack channel last month as a pinned post.

But my changes were in a branch which was created from the deploy branch, so am I supposed to do everything from develop-postgres branch?

@palisadoes
Copy link
Contributor Author

Yes

@palisadoes palisadoes moved this from Backlog to In progress in Talawa-Admin (Tests) Dec 1, 2024
@shivasankaran18
Copy link
Contributor

@AnshulKahar2729 still working on it ?..If not, can I be assigned for this issue?

@palisadoes
Copy link
Contributor Author

unassigning, inactivity

@Aad1tya27
Copy link
Contributor

Can I work on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers test Testing application
Projects
Archived in project
Development

No branches or pull requests

6 participants