Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor : src/components/Advertisements/Advertisements.test.tsx from Jest to Vitest #2486

Closed
prayanshchh opened this issue Nov 27, 2024 · 5 comments
Closed

Refactor : src/components/Advertisements/Advertisements.test.tsx from Jest to Vitest #2486

prayanshchh opened this issue Nov 27, 2024 · 5 comments
Assignees
@khushipatil1523
Labels
good first issue Good for newcomers refactor Refactor the code to improve its quality test Testing application

Comments

@prayanshchh
Copy link
Contributor

Is your feature request related to a problem? Please describe.

This file is currently tested using Jest. As part of our migration to Vitest, we need to refactor this file's test cases to align with Vitest's syntax and features.

Acceptane Criteria

  1. Replace Jest-specific functions and mocks with Vitest equivalents and rename from test.tsx to spec.tsx
  2. Ensure all tests in src/components/Advertisements/Advertisements.test.tsx pass after migration using npm run test:vitest
  3. Maintain the test coverage for the file as 100% after migration
  4. Upload a video or photo for this specific file coverage is 100% in the PR description

Additional context

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship
@github-actions github-actions bot added documentation Improvements or additions to documentation refactor Refactor the code to improve its quality test Testing application unapproved labels Nov 27, 2024
@khushipatil1523
Copy link
Contributor

hey @prayanshchh can i work on these issue

@palisadoes palisadoes added good first issue Good for newcomers and removed documentation Improvements or additions to documentation labels Nov 28, 2024
@palisadoes palisadoes moved this from Backlog to In progress in Talawa-Admin (Tests) Dec 1, 2024
@palisadoes palisadoes moved this from Backlog to In progress in Talawa Admin - Refactoring Dec 1, 2024
This was referenced Dec 7, 2024
Closed
Closed
This was referenced Dec 16, 2024
Closed
Merged
khushipatil1523 added a commit to khushipatil1523/talawa-admin that referenced this issue Dec 19, 2024
@khushipatil1523
Refactored Advertisements test from Jest to Vitest PalisadoesFoundati…
2958074 
…on#2486
@coderabbitai coderabbitai bot mentioned this issue Dec 19, 2024
Closed
khushipatil1523 added a commit to khushipatil1523/talawa-admin that referenced this issue Dec 20, 2024
@khushipatil1523
Refactored Advertisements test from Jest to Vitest PalisadoesFoundati…
82f363e 
…on#2486
This was referenced Dec 21, 2024
Closed
Merged
palisadoes pushed a commit that referenced this issue Dec 22, 2024
@khushipatil1523
convert from jest to vitest #2486 (#2705)
cda2836 
* convert from jest to vitest

* changes done

* changes done

* changes done
palisadoes added a commit that referenced this issue Dec 22, 2024
@palisadoes
Revert "convert from jest to vitest #2486 (#2705)"
5991b74 
This reverts commit cda2836.
palisadoes added a commit that referenced this issue Dec 22, 2024
@palisadoes
Revert "convert from jest to vitest #2486 (#2705)" (#2731)
986bef8 
This reverts commit cda2836.
@coderabbitai coderabbitai bot mentioned this issue Dec 24, 2024
Merged
@palisadoes
Copy link
Contributor

@khushipatil1523

You made a typo in your PR template which made me think you had not been assigned the original issue. Please resubmit your PR.

@gurramkarthiknetha
Copy link
Contributor

If no one is currently working on this issue, I would like to take it on. Please assign it to me.

@khushipatil1523 khushipatil1523 mentioned this issue Dec 24, 2024
Merged
@khushipatil1523
Copy link
Contributor

@palisadoes I sincerely apologize for the typo in my PR template that led to the confusion. I've corrected the mistake and resubmitted the PR for your review. Thank you for understanding!

@coderabbitai coderabbitai bot mentioned this issue Dec 24, 2024
Closed
@palisadoes
Copy link
Contributor

Glad you're back.

@github-project-automation github-project-automation bot moved this from In progress to Done in Talawa Admin - Refactoring Dec 24, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Talawa-Admin (Tests) Dec 24, 2024
This was referenced Dec 25, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khushipatil1523 khushipatil1523

Labels
good first issue Good for newcomers refactor Refactor the code to improve its quality test Testing application
Projects
Talawa Admin - Refactoring
Status: Done
Talawa-Admin (Tests)
Archived in project
Milestone
No milestone
Development

No branches or pull requests
5 participants
@palisadoes @varshith257 @prayanshchh @khushipatil1523 @gurramkarthiknetha