Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CSS files in src/screens/ForgotPassword #2506

Closed
AVtheking opened this issue Nov 30, 2024 · 6 comments
Closed

Refactor CSS files in src/screens/ForgotPassword #2506

AVtheking opened this issue Nov 30, 2024 · 6 comments
Assignees
Labels
feature request good first issue Good for newcomers refactor Refactor the code to improve its quality ui/ux issue related and being worked with the figma file of the Admin UI unapproved

Comments

@AVtheking
Copy link
Contributor

Refactor CSS files in src/screens/ForgotPassword

To improve the UI/UX of Talawa-Admin we have been working on:

  1. making the application more suitable to color blind users
  2. streamlining all CSS into a single global file

Additional information:

  1. The foundational work for this was completed in this PR:
  2. The desired single CSS file is:
    • src/style/app.module.css

The challenge:

The goal is to convert the CSS file in this subdirectory and all the components related to this screen to use this new design pattern. This means that:

  1. All CSS files in this subdirectory and all the CSS files in related components must be merged into the global CSS file using pre-existing CSS.
  2. All CSS files in this subdirectory and all the CSS files in related components must be deleted after the merge.
  3. The remaining relevant files in this subdirectory must only reference the global CSS file.
  4. All the CSS files in the related components of this subdirectory must adhere to the same guidelines.
@devender18
Copy link
Contributor

@AVtheking could you please assign this to me ?

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Dec 25, 2024
@palisadoes
Copy link
Contributor

palisadoes commented Dec 25, 2024

@devender18

Unassigning due to inactivity and/or no submitted PR. Others need to get a chance. Please let us know whether you want to be reassigned before someone else requests assignment or select another issue.

@gurramkarthiknetha
Copy link
Contributor

If no one is currently working on this issue, I would like to take it on. Please assign it to me.

@devender18
Copy link
Contributor

Hi @palisadoes , could you please re-assign this task to me? I've already created the PR, but there are some failing checks that need to be investigated. The failures seem to be related to the tests, and since my changes are limited to the CSS file, there shouldn’t be any issues with the functionality. However, I will look into why the test cases are failing and address the problem accordingly.

@github-actions github-actions bot removed the no-issue-activity No issue activity label Dec 26, 2024
@palisadoes
Copy link
Contributor

With this issue we are migrating from the previous green based color scheme where the #31bb6b color was used for many elements to one using a color scheme similar to that of Gmail.

This makes the app more usable for people with red/green color blindness

When making your changes, make the effort to use pre-existing colors in the src/style/app.module.css file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request good first issue Good for newcomers refactor Refactor the code to improve its quality ui/ux issue related and being worked with the figma file of the Admin UI unapproved
Projects
Status: Done
Development

No branches or pull requests

4 participants