Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CSS files in src/screens/OrganizationPeople #2517

Closed
AVtheking opened this issue Nov 30, 2024 · 9 comments
Closed

Refactor CSS files in src/screens/OrganizationPeople #2517

AVtheking opened this issue Nov 30, 2024 · 9 comments
Assignees
Labels
feature request good first issue Good for newcomers refactor Refactor the code to improve its quality ui/ux issue related and being worked with the figma file of the Admin UI

Comments

@AVtheking
Copy link
Contributor

Refactor CSS files in src/screens/OrganizationPeople

To improve the UI/UX of Talawa-Admin we have been working on:

  1. making the application more suitable to color blind users
  2. streamlining all CSS into a single global file

Additional information:

  1. The foundational work for this was completed in this PR:
  2. The desired single CSS file is:
    • src/style/app.module.css

The challenge:

The goal is to convert the CSS file in this subdirectory and all the components related to this screen to use this new design pattern. This means that:

  1. All CSS files in this subdirectory and all the CSS files in related components must be merged into the global CSS file using pre-existing CSS.
  2. All CSS files in this subdirectory and all the CSS files in related components must be deleted after the merge.
  3. The remaining relevant files in this subdirectory must only reference the global CSS file.
  4. All the CSS files in the related components of this subdirectory must adhere to the same guidelines.
@github-actions github-actions bot added refactor Refactor the code to improve its quality ui/ux issue related and being worked with the figma file of the Admin UI unapproved good first issue Good for newcomers labels Nov 30, 2024
@swastikCommits
Copy link

Please assign me this issue

@amaan-aly246
Copy link
Contributor

Please assign this issue to me.

@amaan-aly246
Copy link
Contributor

I have done the setup for talawa-api and talawa-admin , registered and login in the admin. Bu I'm unable to understand what changes you want. organizationPeople component styles are coming from /style/app.module.css which I think is the global CSS file. I would really appreciate if you could explain with example. Thanks!

@palisadoes
Copy link
Contributor

@AVtheking PTAL

@amaan-aly246
Copy link
Contributor

@palisadoes I have made changes in the OrganizationPeople and it's related components ( in develop branch), and but when I ran the tests, 2 tests failed out of 197. These tests are for the OrganizationScreen.tsx and customTableCell.tsx components, but I haven't made any changes to them. The failed test for OrganizationScreen.tsx indicates that it should have a _expand_ccl5z_8 class, but there's no such class in its corresponding CSS file. The failed test for customTableCell.tsx states 'CustomTableCell › renders event details correctly.' What should I do now? Should I push the changes to my fork develop branch or main branch. Thanks.

@palisadoes
Copy link
Contributor

Please do the following:

  1. Base your local branch on the develop-postres branch
  2. Make sure your local branch is not named develop-postres
  3. Submit the PR develop-postres branch
  4. Fix the errors as part of your PR

Sometimes the tests don't work as expected

@amaan-aly246
Copy link
Contributor

I have raised the PR. I want to work on the bug I found in UI of Action Items section of the orgactionitem component. Where when you click on serach / sort/ status button the options list comes underneath the page with scrollbar.
Screenshot 2024-12-14 041359
Screenshot 2024-12-12 174326

So can I raise the issue following the ISSUE_GUIDELINES section or wait till my PR merges ? And Do you guys have slack/discord where I can communicate regarding development doubts and stuff?

@amaan-aly246
Copy link
Contributor

@palisadoes The OrganizationPeople component does not have a dedicated CSS file to move styles from to the global CSS file.
Since it is already importing styles from the global CSS file, this issue can be closed.
Screenshot 2024-12-22 061120

@palisadoes
Copy link
Contributor

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request good first issue Good for newcomers refactor Refactor the code to improve its quality ui/ux issue related and being worked with the figma file of the Admin UI
Projects
Status: Done
Development

No branches or pull requests

4 participants